Giter Site home page Giter Site logo

Comments (9)

absidue avatar absidue commented on June 14, 2024

It works correctly it you pass valid URLs such as https://youtube.com/watch?v=(id) or freetube://https://youtube.com/watch?v=(id), the fact that your previous invalid URLs worked was unintentional, valid URLs have always worked correctly though.

Closing as it is expected behaviour that FreeTube shouldn't be able to handle invalid URLs.

from freetube.

rail5 avatar rail5 commented on June 14, 2024

It works correctly it you pass valid URLs such as https://youtube.com/watch?v=(id) or freetube://https://youtube.com/watch?v=(id), the fact that your previous invalid URLs worked was unintentional, valid URLs have always worked correctly though.

Closing as it is expected behaviour that FreeTube shouldn't be able to handle invalid URLs.

It may have been "invalid," but the "valid" format was never documented, and neither was the change.

from freetube.

absidue avatar absidue commented on June 14, 2024

FreeTube doesn't have a command line interface, the only reason you can even pass a URL to the binary through the args, is that that is how URL scheme handling on Windows and Linux works (in macOS there is a special app event for it).

It was never documented because the URL scheme handling was added so that browser extensions could redirect YouTube URLs to FreeTube. It wasn't a behavioural change, correct URLs worked in older versions and still do in the current one, all that changed is the incorrect URLs no longer work, because they should never have worked in the first place.

Even if it were documented somewhere, which it currently isn't, it would be documented on the docs page https://docs.freetubeapp.io, not burried in some manpage (pretty sure that most cross-platform GUI apps that don't have a CLI, don't ship a manpage).

from freetube.

rail5 avatar rail5 commented on June 14, 2024

I realize that outside of the "Linux world" manpages aren't too terribly common, but within that world they tend to be the first place many of us look to find this kind of info -- otherwise we just end up guessing, often incorrectly like I did. Maybe it's silly, but it's just how we are
Thanks for the info by the way, even if it doesn't end up getting added to the docs I was at least able to patch the tiny browser addon I maintain to open YT links in FreeTube

from freetube.

absidue avatar absidue commented on June 14, 2024

Is there a reason you decided to write your own browser extension instead of just using one of the many already out there?

from freetube.

rail5 avatar rail5 commented on June 14, 2024

There is, I wanted to have one which added an option to open in FreeTube to the context menu rather than opening in FreeTube by default. The only other addon I'm familiar with is Privacy Redirect, which doesn't have this option -- if you know of one which does though I'd be happy to drop mine

from freetube.

absidue avatar absidue commented on June 14, 2024

I'm very surprised that a Linux users first place to look for documentation on a cross-platform GUI app would be some command line tool and not inside the app itself. The docs website is currently linked on the about page inside the app, in the README in this repo, on the website and even in the very issue template that you just filled in.

However if some Linux users are still unable to find it, then maybe it's worth adding a manpage that just links to the docs website, no point maintaining two different sets of documentation, especially for a program that doesn't have a CLI.

from freetube.

absidue avatar absidue commented on June 14, 2024

There is, I wanted to have one which added an option to open in FreeTube to the context menu rather than opening in FreeTube by default. The only other addon I'm familiar with is Privacy Redirect, which doesn't have this option -- if you know of one which does though I'd be happy to drop mine

I think the maintained fork of Privacy Redirect, libredirect, adds itself to the context menu, so you could use that, not sure if you can disable the open by default behaviour.

from freetube.

rail5 avatar rail5 commented on June 14, 2024

There is, I wanted to have one which added an option to open in FreeTube to the context menu rather than opening in FreeTube by default. The only other addon I'm familiar with is Privacy Redirect, which doesn't have this option -- if you know of one which does though I'd be happy to drop mine

I think the maintained fork of Privacy Redirect, libredirect, adds itself to the context menu, so you could use that, not sure if you can disable the open by default behaviour.

Thanks! I'll check it out

The only reason manpages are so popular is to have one "centralized" location for manuals, one "standard" way of finding them for any app -- it's obviously not a "necessity" strictly speaking, but for a lot of people who've been using *nix systems for decades, it's just instinct. I should say that I did fall back on a Google search which led me to the docs page afterward, and I don't think it's absolutely unreasonable to rely on users going to that page. (The valid URL scheme though, as you mentioned, isn't currently documented)

from freetube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.