Can't decode valid JSON from Azure AD

[freizl]

Can't decode valid JSON from Azure AD

[freizl]

• The parsing error due to the problem found at #65
• dig more I think the problem is that handleResponse (definition below) expects successful response but error.
• rather invoke parseResponseJSON . handleResponse, you might want to write your own handle response function to log out the response in string and response code to see what's going on

handleResponse :: FromJSON err => Response BSL.ByteString -> OAuth2Result err BSL.ByteString
handleResponse rsp =
    if HT.statusIsSuccessful (responseStatus rsp)
        then Right $ responseBody rsp
        else Left $ parseOAuth2Error (responseBody rsp)

[freizl]

@2piix
do you have any update?

[cbeav]

Yo! Hoping to revive this, came across the same issue this week, buried in the same misleading error. Took me a second to diagnose it here.

The problem in parsing the JSON above is this line:

"expires_in": "3599"

You'll note this doesn't play well with the default Aeson parsing definition of Maybe Int present in the OAuth2Token data definition:

hoauth2/src/Network/OAuth/OAuth2/Internal.hs

Lines 53 to 59 in c289d68

	data OAuth2Token = OAuth2Token {
	accessToken :: AccessToken
	, refreshToken :: Maybe RefreshToken
	, expiresIn :: Maybe Int
	, tokenType :: Maybe Text
	, idToken :: Maybe IdToken
	} deriving (Show, Generic)

I think it would be cool to try to parse Int using withText upstream, but maybe not worth fighting that battle for this one fix.

How would we feel about me writing a custom fromJSON for OAuth2Token here with the flexibility of parsing from a string in addition to the default Int parser?

[cbeav]

Suggestions for how to do this more cleanly welcome:

data OAuth2Token = OAuth2Token {
      accessToken  :: AccessToken
    , refreshToken :: Maybe RefreshToken
    , expiresIn    :: Maybe Int
    , tokenType    :: Maybe Text
    , idToken      :: Maybe IdToken
    } deriving (Show, Generic)

parseIntFlexible :: Value -> Parser Int
parseIntFlexible (String s) = pure . read $ unpack s
parseIntFlexible v = parseJSON v

-- | Parse JSON data into 'OAuth2Token'
instance FromJSON OAuth2Token where
    parseJSON = withObject "OAuth2Token" $ \v -> OAuth2Token
        <$> v .: "access_token"
        <*> v .:? "refresh_token"
        <*> explicitParseFieldMaybe parseIntFlexible v "expires_in"
        <*> v .:? "token_type"
        <*> v .:? "id_token"
instance ToJSON OAuth2Token where
    toJSON = genericToJSON defaultOptions { fieldLabelModifier = camelTo2 '_' }
    toEncoding = genericToEncoding defaultOptions { fieldLabelModifier = camelTo2 '_' }

[freizl]

1.8.1 was released and let me know if it solved your problem. thank you for reporting the problem.

[cbeav]

Good to go, feel free to close this out!