Regression regarding `resolveOnMainThread `

[freshos]

Regression regarding `resolveOnMainThread `

[s4cha]

Hi @alladinian @maxkonovalov ,
This should be solved in 3.0.0 (Swift 4) 🎉
Thanks a ton!

[s4cha]

@alladinian Thanks a lot for reporting this.
Indeed latest version uses latest then version that has been patched for some retain cycles.
Looks like the patch ends up changing the behaviour down the road...
I'll try to look at this this week and keep you posted :)

[s4cha]

@alladinian I haven't forgotten you :)

I've been working on an update for then (freshOS/Then#29)
I'm curious if that would solve your issue and the regressions you pointed out.

Could you elaborate a bit more so that we can test it out ?

Have a wonderful weekend,

[alladinian]

@s4cha Hi there!
No worries, I appreciate it :)
You're right, I should have elaborated more on this.

The problem I stumbled upon was related to resolveOnMainThread() so I don't think this is an issue of then library.

The implementation of the function captures self (an instance of a Promise) as weak, which means that if we do not hold a strong reference to the promise on which we chained a resolveOnMainThread(), we break the whole chain (since the first promise is deallocated when we reach the end of the local scope - see my example above. Just fill the blanks with print statements & you should be able to verify that finally/hideLoading() is never called...).

The problem is solved by not specifying the captured self as weak, but I did not verify that it doesn't introduce any memory leaks...

I hope that this makes sense and it's helpful to you,

Thanks again for this great project,

Vasilis

[maxkonovalov]

Hey guys, I can confirm that resolveOnMainThread() stopped working for me, too. The resulting then, onError, etc. never get called. I tried to keep a strong ref to the returned Promise, but it didn't help either.

[s4cha]

@alladinian can we close this issue?

[alladinian]

@s4cha Sure, seems to be fixed. Also... Happy new year guys 🍻

[s4cha]

Yeah! You to @alladinian thanks again for your time and effort !!!
Let 2018 be awesome!!!! 🍾