Incrementor in for loop not corrected

[HelloGrayson]

Incrementor in for loop not corrected

[keradus]

@breerly could you provide a PSR rule for that ?

[HelloGrayson]

Probably not, haven't been using PHP lately.

[GrahamCampbell]

This would still be a good contrib fixer, or even symfony level?

[keradus]

Yes.
I would even changed it into ++$i

Nevertheless it is a nice info is this should be at PSR level or not.

[GrahamCampbell]

++$i is technically different though.

[keradus]

Yes. You can change blindly $a ++ into $a++.

And you can also change knowingly $a++ into ++$a - eg already provided by @breerly ;)

[vbence]

It does not say, just gives an example, which is quite insufficient knowing the various uses of the C-style for loop.

What I get away from this:

• Operators with two operands (= < > etc.) should be surrounded by spaces (I wonder if this is not covered elsewhere).
• There should be no space between the variable and the ++.

---

Excerpt from PSR-2:

5.4. for

A for statement looks like the following. Note the placement of parentheses,
spaces, and braces.

<?php
for ($i = 0; $i < 10; $i++) {
    // for body
}

[keradus]

Operators like < aren't relevant here.
Example didn't say that one should use post- or pre- incrementation.

[vbence]

I think the whole spacing issue in a for loop deserves to be looked at. Whether or not pre-incrementation is allowed I think the following examples are all wrong:

// too many spaces
for ($i = 0; $i < 10; $i ++) {

// too many spaces
for ($i = 0; $i < 10; ++ $i) {

// too few spaces
for ($i=0; $i<10; $i++) {

// incredibly few spaces
for ($i=0;$i<10;$i++) {

[stof]

@vbence most of the cases in your comment are already fixed by the fixer enforcing spaces around binary operators

[vbence]

@stof I think operators_spaces [symfony] is the one, but it is outside PSR-2 level.

[stof]

@vbence indeed, because PSR-2 does not define any rules about using spaces or no around operators.

[vbence]

@stof I guess it's up for interpretation. I quoted the doc in my first comment.

Are you saying the following is valid PSR2?

   for ($i=0;$i<10;$i ++) {

[stof]

@vbence read what the section 5 is defining in the spec. Your snippet is technically valid, because it has the parentheses, braces and spaces in the places defined in the spec. The section 5 is not about spaces around operators or between statements (Symfony on the other hand defines such a rule, making your snippet invalid for the Symfony coding standards)

[gharlan]

This issue is fixed by #1064 and can be closed.

[keradus]

Thank you. Closing