Comments (9)
Hi,
i think we could split master into separate branch for each Symfony version.
But we need to change the tagging method as you noticed.
Maybe something like this :
2.2.9.1 for Froala 2.9.1 under Sf2,
3.2.9.0 for Froala 2.9.0 under Sf3 etc...
Actually i'm not using Symfony anymore, so my old project is still in Sf 2, i can maintain this version.
from kmsfroalaeditorbundle.
I guess I could, but I'm going to need some time for that :) And for Symfony 4 deprecations removal as well.
Also I'd like your feedback (from both of you :)) about the following topics:
- phpstan integration
- phpcs integration
- adding tests
I guess the last point won't be an issue :D
from kmsfroalaeditorbundle.
Hi @sguionni, what do you think about this issue?
Could the bundle drop support for Symfony < 3 (or even < 4)?
from kmsfroalaeditorbundle.
@jmsche @sguionni I believe we could make a separate branch for Symfony 2 / 3 and then continue with master on Symfony 4. What do you think?
from kmsfroalaeditorbundle.
@stefanneculai I'm ok with that, but we should change the release process / tagging; IMO making a release for each Froala editor version is not great :/
What about creating a download command like FOSCKEditorBundle does? Seems to work well.
Also, we could list other stuff we'd want to do if we break the current release process. Eg. phpstan/phpcs integration?
from kmsfroalaeditorbundle.
Looking for some input from @sguionni. Thanks in advance.
from kmsfroalaeditorbundle.
If you're ok with this I'd be more in favor (at least for new releases that wouldn't support Symfony 2 anymore) for a download command, as described in my previous comment.
So new releases would bring new features, and developers wouldn't rely on a new release of this package to use the latest Froala Editor release :)
An other issue with your tagging proposal is, introducing tags like 2.2.9.1
while 2.9.1
has already been released is somehow confusing, and I'm not even sure what I'd put in my composer.json file as a constraint to make it work :/
from kmsfroalaeditorbundle.
I think we could actually make a separate branch for S2 and keep master branch for S3/S4. On the branch with S2, we can just rename the package to KMS2-FroalaEditorBundle and keep the same tagging as up to now.
I am good with the command, @jmsche. Do you think you could make a PR for it?
from kmsfroalaeditorbundle.
Added most of the changes (install command, Symfony 4.3+ support, Symfony 2/3 support removal...) into PR #89.
Opened issues #90 for docs update & #91 about code style/static analysis.
from kmsfroalaeditorbundle.
Related Issues (20)
- Editor not display with toolbarinline option is true HOT 5
- Alert is seen after image or video uplaod and click outside HOT 1
- Problem with quick insert icons HOT 1
- How to work with Froala inside a form with multiple fields ? HOT 2
- Use CodeMirror twig ?
- Error 1 image cannot be loaded on Froala Symfony 4.x HOT 6
- Froala image upload to Filestack
- getPdf and spellChecker plugins does nothing HOT 3
- Will there be multiple css and/or js files included? HOT 3
- Why tag 4.0.0? HOT 8
- Bug froala_widget.html.twig HOT 1
- Fail to display on EasyAdminBundle HOT 2
- Support for php 8.1 and Symfony 6 HOT 2
- Uncaught ReferenceError: $ is not defined HOT 19
- How to handle Images/Files deletion via events ? HOT 2
- Font Awesome 3rd Party Plugin not enabled in config HOT 1
- Drop-downs of second tool bar are not opening when text is selected in IOS HOT 1
- Attempted to load class "Inflector" from namespace "Doctrine\Common\Util". HOT 2
- Documentation follow-up for the massive upgrade HOT 2
- Code style/static analysis HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kmsfroalaeditorbundle.