Giter Site home page Giter Site logo

Comments (4)

frostschutz avatar frostschutz commented on July 23, 2024

Good find.

Same problem affects external SD cards (for those devices that still come with microsd slots) as well. Which device(s) are you using / did you test this on?

blkid is also called with parameters (like blkid $DEVNAME in Kobo/udev/sd), your solution doesn't keep this parameter, so it will likely cause other problems to appear.

There doesn't seem much alternative to messing with blkid. Perhaps we could keep the original output and just add the fake output as an extra line, as the current scripts do filtering with grep, they would be happy and whoever wants the real information would also be happy...

I'll have to do some testing for this thing. ;)

from kobo.

mek-apelsin avatar mek-apelsin commented on July 23, 2024

I admit at being lazy, this fixed it for me (on a GloHD). I don't have a reader with an external slot, and I am pretty sure I would gobble it up if I guessed how they worked. I missed accepting arguments for blkid, added a diff. I am unsure if it would be better or worse duplicating lines with different TYPEs.

from kobo.

frostschutz avatar frostschutz commented on July 23, 2024

Accepting the pull request, we can always improve it later. Thanks for contributing! :)

from kobo.

frostschutz avatar frostschutz commented on July 23, 2024

(Leaving the issue open for said improvements.)

from kobo.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.