Giter Site home page Giter Site logo

Comments (6)

darvoso avatar darvoso commented on July 26, 2024

while not a fix, if you go back to the v23.03.07-release of the reborn version the (above) errors go away (for me).

from tiptac.

frozn avatar frozn commented on July 26, 2024

Thanks for reporting this! 👍

It seems that some other addon is leaking globals, in this case the variable Settings. This global variable is only available in retail but not in WotLKC. The line of code in the first error mesage you posted (attempt to call field 'RegisterCanvasLayoutCategory') shouldn't be executed in WotLKC.

Please try by disabling some of your addon to determine the causing addon.

from tiptac.

darvoso avatar darvoso commented on July 26, 2024

I finally remembered to do this: https://www.curseforge.com/wow/addons/profession-master was the culprit (for me).

from tiptac.

frozn avatar frozn commented on July 26, 2024

Thank you for finding this out! 👍

Profession Master is currently leaking a lot of global variables, see "ProfessionMaster.lua" on top in section "prepare storage" and function "ProfessionMasterAddon:CheckSettings()". In the mentioned function the global variable "Settings" will be created if it doesn't exist. But this variable is also used by blizzard.

In the latest release of TipTac Reborn I added the feature that the menu of TipTac can also be popped up in WoW's interface settings. Because the retail flavor has a new interface settings style I differentiate the insertion of TipTac's settings into the interface settings by checking if global variable "Settings" is available. If so, I assume that the new interface settings style is available and call the appropriate blizzard functions, which doesn't exist if Profession Master is active.

Because there's no source code available on GitHub I can't make a pull request to show a possible solution for Profession Master. But I can solve this temporary on TipTac's side too by not only checking if global variable "Settings" is availble but also if e.g. function "Settings.RegisterCanvasLayoutCategory()" is available. This will be included in the next release.

Nevertheless, the problem with leaking of global variables has to be solved in Profession Master.

from tiptac.

darvoso avatar darvoso commented on July 26, 2024

Thank you for being willing to solve around it so I (we?) can use both.

from tiptac.

frozn avatar frozn commented on July 26, 2024

Fixed with release v23.05.01.

from tiptac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.