Giter Site home page Giter Site logo

Comments (7)

frozn avatar frozn commented on July 26, 2024 1

Strange, because "milstoneInfo.rank" is used here (a few lines later): https://www.townlong-yak.com/framexml/live/Blizzard_AzeriteEssenceUI/Blizzard_AzeriteEssenceUI.lua#110

But I think this is used here for something else. I added your suggestion to main-branch.

from tiptac.

hobulian avatar hobulian commented on July 26, 2024 1

Working perfect!

from tiptac.

frozn avatar frozn commented on July 26, 2024

I played battle for azeroth for 3 hours at the time. 🙈 So I haven't unlocked anything about the heart of azeroth.

I added a hook to GameTooltip:SetAzeriteEssence() and add some options to "ItemRef":

  • added border color and infos for azerite essences
  • added mouseover for azerite essences

Is everything working here, or is something still missing?

from tiptac.

hobulian avatar hobulian commented on July 26, 2024

First time it seemed to working well but have 2 problems.

First is that It worked on AzeriteEssenceUIScrollChild but didn't on AzeriteEssenceUI.~~.UnlockedState(Socket Frame).
https://imgur.com/a/4D3pEKg

Second one is quite serious problem. After clicking chat linked Azerite Essence and popping up ItemRefTooltip For azerite essence, every clicking on default UI(Except ActionBar) such as minimap, chat window, player unit frame or pet's or objective window(quest, etc..) goes broken. You cannot right or left click them, while you can click action bar or bag items or other window's clickable objectives.
I checked that this can happen only with tiptac loaded

from tiptac.

frozn avatar frozn commented on July 26, 2024

I fixed the problem after clicking chatlink of azerite essence. Additionally I added a hook to GameTooltip:SetAzeriteEssenceSlot(). Because I haven't unlocked a slot yet, can you test if it works? 👍

from tiptac.

hobulian avatar hobulian commented on July 26, 2024

I fixed the problem after clicking chatlink of azerite essence. Additionally I added a hook to GameTooltip:SetAzeriteEssenceSlot(). Because I haven't unlocked a slot yet, can you test if it works? 👍

It worked on clicking problem but I think on Azerite Slot quality border problem it's still same.
https://imgur.com/a/Rj4Sxi5

P.S
Found out that

essenceRank(local essenceRank = milestoneInfo.rank;) in
local function SetAzeriteEssenceSlot_Hook(self, slot)

should be

local essenceRank = C_AzeriteEssence.GetEssenceInfo(essenceID).rank;

since milestoneInfo table doesn't have rank info(While it's written on https://wowpedia.fandom.com/wiki/API_C_AzeriteEssence.GetMilestoneInfo but seems it does not rend me rank info when tested)

After changed that it worked.

from tiptac.

frozn avatar frozn commented on July 26, 2024

Works fine with actual version?

from tiptac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.