Giter Site home page Giter Site logo

Comments (5)

fruffy avatar fruffy commented on June 19, 2024

This is a bug in the dead code eliminator, less so in the analysis. It used to be the case that only NoAction was removed, but we should instead substitute the apply call with the default action instead if a table is removed.

from flay.

RabbitWhite1 avatar RabbitWhite1 commented on June 19, 2024

I see. I found that defaultonly actions are filtered out in the dead code eliminator. Can we simply transform the apply call to the default action call right before here if the default action for this table is specified?

from flay.

fruffy avatar fruffy commented on June 19, 2024

Yes, we basically retrieve the default action from the table. We can check whether the body is empty, too.

from flay.

RabbitWhite1 avatar RabbitWhite1 commented on June 19, 2024

Great. I will submit a pr to fix this.

from flay.

RabbitWhite1 avatar RabbitWhite1 commented on June 19, 2024

Fixed by #56. Also updated reference files. PTAL @fruffy

from flay.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.