Constructor parameters are mistaken for record fields in classes

[ovatsus]

Constructor parameters are mistaken for record fields in classes

Fix is probably here, adding the second line below:

        entity.AllFieldsAsList
        |> List.filter (fun x -> not x.IsCompilerGenerated)
        |> List.map (fun x -> FSharpRecordField(g,  RecdFieldData.Recd (mkRecdFieldRef entity x.Name)))

Reviewing the use of FSharpRecordField and the data on the corresponding RecdField in the F# compiler, there are some other issues too.

• It looks like it is really be renamed to "FSharpField", i.e. including class fields (it already includes union fields)
• There are other attributes we should reveal, e.g. IsStatic, IsVolatile, IsZeroInit (called UsesDefaultValue when we expose it?).
• There is a question of how F# enum declarations will look through the API. Although enum declarations look superficially like union declarations in the syntax of the language, inside the compiler they are represented as an object model type with a set of static fields, each with a literal value. This is because thi is how they are compiled in .NET. We should probably just reveal these like this in the API, it's the simplest thing to do. This means FSharpField would need a LiteralValue property.

[ovatsus]

Is anyone going to work on this?

See 0.0.14. There is a property IsCompilerGenerated on FSharpField, FSharp.Formatting should now filter for that.