Giter Site home page Giter Site logo

Comments (11)

 avatar commented on June 19, 2024

One concern is that this approach still won't work for mixed-language solutions.

Presumably in XS and Roslynified-VS the idea is to draw cross-project metadata from the symbol APIs provided by the IDE. But that's a big change for FCS.

I suppose enabling single -language cross-project in FCS is still the best thing to do (particularly for F# projects that have a corresponding unit test project, for example)

from fsharp-compiler-docs.

7sharp9 avatar 7sharp9 commented on June 19, 2024

In XS this would be done be creating a larger NRefactory bridge from the data FCS returns. Building up from compilation units etc.

from fsharp-compiler-docs.

7sharp9 avatar 7sharp9 commented on June 19, 2024

It would be nice if symbol requests for different project were aggregated inside FCS, so that a symbol retrieved from project a could be searched for in project b.

from fsharp-compiler-docs.

 avatar commented on June 19, 2024

Right, but we'd also need the other way around - take NRefactory information and feed it into the F# compiler (a bit like a type provider, actually, and the same codepaths could possibly be used). But its a big change to do this, and in any case cross-language metadata is not yet readily available in VS AFAIK.

Adding F#-to-F# project references to FCS is much more tractable though.

from fsharp-compiler-docs.

7sharp9 avatar 7sharp9 commented on June 19, 2024

As far as XS is concerned NRefactory its supposed to be a language neutral way of storing all that information, csc is used to fill NRefactory with the C# symbol information.

I think the will be a certain gap in services once you try to bridge different IDE's like XS and VS due the the mechanisms involved internally etc.

from fsharp-compiler-docs.

7sharp9 avatar 7sharp9 commented on June 19, 2024

Im not sure if spending time building it is worth it. Cant the symbol finder simply be called once for each project?

from fsharp-compiler-docs.

dungpa avatar dungpa commented on June 19, 2024

One step at a time. I think enabling F# cross-project analysis is already useful in a lot of use cases.

from fsharp-compiler-docs.

7sharp9 avatar 7sharp9 commented on June 19, 2024

Yes, but what Im saying is, can't you do that with the current FCS, get the symbols from each project and search them.

from fsharp-compiler-docs.

dungpa avatar dungpa commented on June 19, 2024

It's doable with current FCS but delegating multi-project analysis to FCS could probably give better performance and incrementality. And it's an IDE-agnostic process which benefits all the clients :).

I understand the concern about mismatch between different IDEs in handling cross-language solutions though.

from fsharp-compiler-docs.

 avatar commented on June 19, 2024

@7sharp9 It's only doable with the current service if compiled DLLs exist for the cross-project references. This also adds an extra level of (largely hidden) state for the user.

from fsharp-compiler-docs.

 avatar commented on June 19, 2024

Some initial support for cross-project references has been added to FCS in 0.0.30.

See “Analyzing multiple projects” in http://fsharp.github.io/FSharp.Compiler.Service/project.html

from fsharp-compiler-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.