Giter Site home page Giter Site logo

Comments (5)

 avatar commented on September 25, 2024

Yes, makes sense

from fsharp-compiler-docs.

 avatar commented on September 25, 2024

@ovatsus The XmlDoc for provided types should already be populated - are you seeing that?

from fsharp-compiler-docs.

ovatsus avatar ovatsus commented on September 25, 2024

In the FSharp.Data.xml file generated by the compiler there's no mention of any of the type providers:

  • CsvProvider
  • JsonProvider
  • XmlProvider
  • FreebaseData
  • FreebaseDataProvider
  • WorldBankData
  • WorldBankDataProvider

The XmlDoc property of the FSharpEntity instances has the comments, but the XmlDocSig property is empty. We're looking for <param> tags there to discover the parameters, but it's a very unreliable way to get the info. You don't get the type of the parameters, the default values, or event the parameters for which there's no documentation. See ovatsus/FSharp.Formatting@a5c6c06#diff-e2212151e1f9b6e7e085820d2a6b71caR572

from fsharp-compiler-docs.

ovatsus avatar ovatsus commented on September 25, 2024

Ah, turns out staticparameters were already there, I missed them. The DefaultValue and IsOptional fields you added are working, but HasDefaultValue is coming always false, even when there is a default value and its correctly populated in the DefaultValue field. I still have to hack around the xml docs, though...

from fsharp-compiler-docs.

ovatsus avatar ovatsus commented on September 25, 2024

As HasDefaultValue is not working, maybe you can remove it, IsOptional is already a good indicator ovatsus/FSharp.Formatting@d6ec05f#diff-e2212151e1f9b6e7e085820d2a6b71caR441

from fsharp-compiler-docs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.