Giter Site home page Giter Site logo

Comments (8)

smoothdeveloper avatar smoothdeveloper commented on July 21, 2024 1

Thanks for the issue report @daniellittledev.

In #362, a workaround was to use nvarchar(max) instead of a specified length, I'm not sure if it would work or if you can use that in meantime the bug get addressed.

I'll try to put this under test and fix the call to SqlMetaData constructor accordingly.

from fsharp.data.sqlclient.

smoothdeveloper avatar smoothdeveloper commented on July 21, 2024 1

@suou-ryuu thanks a lot for the fix PR, with added test.

I'll take a moment to review and run the test locally, and issue a new release when possible.

@daniellittledev, if you happen to test the fix on your own and confirm in meantime, please let us know.

Thanks again all!

from fsharp.data.sqlclient.

suou-ryuu avatar suou-ryuu commented on July 21, 2024

@smoothdeveloper I've submitted a PR with what I think may be the fix for this issue.
Please check it out when you have a minute: #418

from fsharp.data.sqlclient.

suou-ryuu avatar suou-ryuu commented on July 21, 2024

@smoothdeveloper Thanks for the quick reply.

I'll take a moment to review and run the test locally, and issue a new release when possible.

Superb. Looking forward to it :)

from fsharp.data.sqlclient.

suou-ryuu avatar suou-ryuu commented on July 21, 2024

@smoothdeveloper Sorry to pester, but do you have an ETA for when you'll be able to confirm this fix and issue a new release? We currently need this as it's blocking progress on a few projects.

Thank you in advance

from fsharp.data.sqlclient.

smoothdeveloper avatar smoothdeveloper commented on July 21, 2024

@suou-ryuu there should be a 2.1.1 version with your PR changes upon validation from nuget.org.

from fsharp.data.sqlclient.

suou-ryuu avatar suou-ryuu commented on July 21, 2024

@smoothdeveloper Fantastic. Thank you.
I see the 2.1.1 on nuget.org; I've tested it locally and it's all working as expected 😄
Thank you for handling so quickly

from fsharp.data.sqlclient.

smoothdeveloper avatar smoothdeveloper commented on July 21, 2024

@suou-ryuu thanks for confirming on your end and no problems.

Just so you know, once you've got the main library to build, you can generate the nuget package yourself: build NuGet -st

This allows you to drop a new version locally before a release is made.

@daniellittledev if you have a chance to try the new release and if it fixes this issue, we can close it?

Thanks again @suou-ryuu for contributing the fix.

from fsharp.data.sqlclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.