Preserving linefeed style

[arialdomartini]

Preserving linefeed style

[bonjune]

Save () and SaveToString () depends on TextWriter's WriteLine () method to write line terminate at the end of each line.

TextWriter outputs the line terminator which defaults to the system's default.
But it can be changed via setting NewLine property of TextWriter.

Loot at: https://learn.microsoft.com/en-us/dotnet/api/system.io.textwriter.newline?view=net-7.0

I think we can add a optional parameter to the Save () and SaveToString () methods.

cc @cartermp

References

• https://fsprojects.github.io/FSharp.Data/reference/fsharp-data-runtime-csvfile-1.html
• https://learn.microsoft.com/en-us/dotnet/api/system.io.textwriter?view=net-7.0
• https://learn.microsoft.com/en-us/dotnet/api/system.io.textwriter.writeline?view=net-7.0

[arialdomartini]

Yes, that would be useful.
Please, consider that as per the RFC 4180 rule 2.1

| 1. Each record is located on a separate line, delimited by a line break (CRLF)

regardless the hosting OS.

[cartermp]

So I guess this was technically a breaking change, but I think "correctly adhering to the standard" is fine, so this is in, and it'll be a minor version bump because versioning is whatever we want it to be.