Giter Site home page Giter Site logo

Simplify "should throw" about fsunit HOT 5 CLOSED

fsprojects avatar fsprojects commented on May 22, 2024
Simplify "should throw"

from fsunit.

Comments (5)

Evangelink avatar Evangelink commented on May 22, 2024

@sergey-tihon Do you care about retro compatibility? (i.e. should I keep the old method and create a new one?). I am about to do this quick PR.

from fsunit.

sergey-tihon avatar sergey-tihon commented on May 22, 2024

@Evangelink Yes we care about backward compatibility.
I think that we can support this feature in new FsUnit.Typed that is probably will be merged into FsUnit repo.

from fsunit.

Evangelink avatar Evangelink commented on May 22, 2024

Ok cheers! I will have a look.

from fsunit.

Evangelink avatar Evangelink commented on May 22, 2024

@sergey-tihon There is a shouldFail method line 36 (don't know how to link a portion of code) in your commit that already satisfy @tpetricek request.
(fun () -> failwith "BOOM!") |> shouldFail<exn>

Don't think it is worth doing a shouldThrow that will do the same thing (rename current method?). I can add a shouldFailWithMessage method that will also check the error message if wanted.

from fsunit.

sergey-tihon avatar sergey-tihon commented on May 22, 2024

Released in v2.2.0-beta1

from fsunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.