Jasmine Test failure on Safari - Invalid Date

[fulcrum-agile]

Jasmine Test failure on Safari - Invalid Date

[malclocke]

There's some relevant discussion here http://stackoverflow.com/questions/3085937/safari-js-cannot-parse-yyyy-mm-dd-date-format

[cartuchogl]

I patch Date class with the link information and now jasmine test pass, and fulcrum is usable on Safari. I test this on MacOSX 10.6.8 with Safari 5.1 and Safari on IPad

The code:

// if can't parse dates with used format
if(typeof(new Date("2011-11-11"))!=Date) {
  // monkey patch it
  var orig = Date;
  Date = function() {
    if(arguments&&arguments.length>0) {
      if(arguments.length==1) {
        // can I apply the fix?
        if(arguments[0].replace) {
          return new orig(arguments[0].replace(/-/g,"/"));
        } else {
          // fallback
          return new orig(arguments[0]);
        }
      } else {
        // Date(year,month,day,hours,minutes,seconds,milliseconds) contructor
        var a = arguments;
        // how to do "new orig(unpack(args))" like lua?
        return new orig(
          a[0]?a[0]:null,a[1]?a[1]:null,a[2]?a[2]:null,a[3]?a[3]:null,
          a[4]?a[4]:null,a[5]?a[5]:null,a[6]?a[6]:null
        );
      }
    } else {
      return new orig();
    }
  }
}

I added this code on project.spec.js and 67 specs pass, and if I added this to fulcrum.js the app is now functional. I not sure what is the best place for that hack.

[malclocke]

Thanks for that Carlos. I'd prefer a solution that doesn't require a different code path for different browsers. I've pushed a branch called experimental_fix_for_safari_date_parse, any Safari users able to try it?

[malclocke]

Sorry, please ignore the request above. This should be fixed by Kale's code in #18