Comments (6)
I believe this is a bug with KoreSample not RecipeResearch directly.
from reciperesearch.
I guess @ScottKillen should take a look then...
from reciperesearch.
@Funwayguy
The problem is this: You are trying to get a texture for a subblock that does not exist. There is no sane answer that getIcon can give in this case.
This used to be a problem with NEI and other mods, but ChickenBones used exception handling to recover from cases like this...and indeed that is precisely the purpose of exception handling. You can easily catch the IndexOutOfBoundsException and recover in a way that makes sense for your purposes.
You will have this problem with other mods as well if you assume that your requests are always valid.
I hope this is helpful.
BTW, very cool mod idea. 👍
from reciperesearch.
@ScottKillen I will likely add the try-catch statement but the sane answer is to use a modulus call on the sub-block meta number to wrap the ID around into acceptable range. Here's an example for the textbook in this mod:
https://github.com/Funwayguy/RecipeResearch/blob/master/src/main/java/reciperesearch/items/ItemRecipeTextbook.java#L110
It may not be an accurate representation of the block/item with the given damage value but it's better than letting Minecraft crash when somebody does something unexpected.
PS: You could alternatively use 'MathHelper.clamp_int' instead which is what vanilla Minecraft uses in some cases
from reciperesearch.
Handling for this should be covered in 1.0.17 now
from reciperesearch.
Awesome, thank you!
I will do intensive testing over the next couple of days and report back.
This will be an essential part of "Viribus Unitis", I've read and understood your modpack permissions and will act accordingly.
from reciperesearch.
Related Issues (10)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reciperesearch.