Giter Site home page Giter Site logo

Comments (3)

oczkers avatar oczkers commented on May 29, 2024

Don't you think it should be checked in higher layer?

This change would prevent overbid at all - official webapp allows it so i think it shouldn't be limitted.

from fut.

mvillarejo avatar mvillarejo commented on May 29, 2024

Well we can always send a flag in the call like overbid=True, so we just need to check the value before and after.

from fut.

oczkers avatar oczkers commented on May 29, 2024

There is no need to check bidState after bid (it'll return False if bid was unsuccessful).

Bid method is making one request to server (getting item info) before checking bidState so checking it before calling bid is much better solution (performance etc.).

from fut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.