Giter Site home page Giter Site logo

Comments (4)

PrParadoxy avatar PrParadoxy commented on September 23, 2024 1

Hauler default animation for swiping down was problematic on that specific device. So naturally I tried to change it. The code I posted above works in exact opposite way, which would let activity to be dismissed on top of screen not the bottom. I am referring to this post https://stackoverflow.com/a/59560922/12149190. But I had the same issue with it.

So in the end I fixed this by changing that animation to https://android.googlesource.com/platform/frameworks/base/+/HEAD/core/res/res/anim/slide_in_right.xml. Thank you for responding, good job keep it up.

from hauler.

skywall avatar skywall commented on September 23, 2024

Hi @PrParadoxy,
thank you for your report. Let's address both of your problems:

  1. We have mentioned Samsung device, and we can reproduce your issue. We don't want to force change this default device behavior for all users of a library, but you can change it in your use case. Take a look at https://github.com/futuredapp/hauler/blob/master/sample/src/main/kotlin/com/thefuntasty/haulersample/draggable/advanced/AdvancedActivity.kt#L28. You have to override default Activity animation to custom one (swipe down in this case).
  2. Can you give us more information about android:fillViewport? Screenshots or videos of an issue will be very beneficial.

Thanks.

from hauler.

PrParadoxy avatar PrParadoxy commented on September 23, 2024

Hi @skywall
Thank you for your response.

  1. Fixing this would be easy, but I don't understand why "R.anim.anim_slide_down" should show such a weird behavior on that device to begin with, maybe for tablets we don't have

<set xmlns:android="http://schemas.android.com/apk/res/android" >
    <translate
        android:duration="200"
        android:fromYDelta="-100%"
        android:toYDelta="0" />
</set> 

anymore, and something else is called from sw600dp version of it.

  1. After more inspection, I understood that there is nothing wrong with Hauler, rather in very large devices, android:fillViewport is problematic itself.

from hauler.

skywall avatar skywall commented on September 23, 2024
  1. Where did you get mentioned R.anim.anim_slide_down? The code snippet you've posted represents swipe up animation. To be honest I'm a bit lost and not sure what issue you're currently facing.

from hauler.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.