Giter Site home page Giter Site logo

Comments (8)

fzaninotto avatar fzaninotto commented on August 17, 2024

Which are the ways you think about?

from faker.

geoffrey-brier avatar geoffrey-brier commented on August 17, 2024

I was speaking of throwing an exception or returning an empty string.
Throwing an exception will inform the user that something is wrong but will still stop the application if not catched.
Returning an empty string will let the application continue but the developer may not know why he may have empty data in his/her dataset.

I think throwing an exception is the best solution. What do you think?

from faker.

fzaninotto avatar fzaninotto commented on August 17, 2024

Or, we could think about another way to randomize the number of words. Like:

if ($nbWords != 0) {
  $nbWords = $nbWords * mt_rand(60,140)/100) + 1;
}

I think the method should accept $nbWords equal to zero and return an empty string in that case.

from faker.

geoffrey-brier avatar geoffrey-brier commented on August 17, 2024

Deal :)

from faker.

fzaninotto avatar fzaninotto commented on August 17, 2024

Could you write a PR for that?

from faker.

geoffrey-brier avatar geoffrey-brier commented on August 17, 2024

Sure, I'll do this tonight or by the end of the week.

from faker.

geoffrey-brier avatar geoffrey-brier commented on August 17, 2024

I think you can close this issue too

from faker.

fzaninotto avatar fzaninotto commented on August 17, 2024

Sure!

from faker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.