Giter Site home page Giter Site logo

Comments (9)

adamstruck avatar adamstruck commented on June 9, 2024 2

Couldn't this be achieved using the ListWorkflows endpoint with filtering?

from workflow-execution-service-schemas.

brucehoff avatar brucehoff commented on June 9, 2024 1

Couldn't this be achieved using the ListWorkflows endpoint with filtering?

Yes, that is a good point. @david4096 also makes a good suggestion to determine the subset by passing a list of IDs. This relieves the WES implementation from having to implement filtering, sorting, etc. Please also see #23 which requests richer status than just a "state" string, (percent complete or other progress information). To me ideally the ListWorkflows would accept a list of IDs and return a list of maps (sets of key-value pairs) containing status metadata for the workflow. It seems to me that we would also need an endpoint to POST status information, that endpoint callable by the workflow itself.

from workflow-execution-service-schemas.

brucehoff avatar brucehoff commented on June 9, 2024

This would allow a client to display for the user a dashboard of running workflows (retrieving, say, a page at a time rather than making a new request for each row of the table).

from workflow-execution-service-schemas.

david4096 avatar david4096 commented on June 9, 2024

@adamstruck yes! One way to close this would be to add a parameter workflow_ids that accepts an array of strings in the workflow_list_request and will only return workflows with the provided identifier in a ListWorkflowResponse.

from workflow-execution-service-schemas.

david4096 avatar david4096 commented on June 9, 2024

Thanks @brucehoff , to actually close this, one would need to get the workflow logs using a filtered list, not just the list of workflows.

from workflow-execution-service-schemas.

cjllanwarne avatar cjllanwarne commented on June 9, 2024

Pinging @vsmalladi and @patmagee - this is coming up as a would-be-useful feature for us too (updating CBAS to monitor run statuses in batches). I imagine that having some way to filter results would be useful for anyone who ends up with more than a handful of runs to query against in their engine. Would it be worthwhile me making an implementation PR to modify ListWorkflows with filter options as suggested above?

from workflow-execution-service-schemas.

vsmalladi avatar vsmalladi commented on June 9, 2024

@cjllanwarne I think its worth making the PR and then discussing where there might be issues.

from workflow-execution-service-schemas.

patmagee avatar patmagee commented on June 9, 2024

@cjllanwarne I agree, if you have the bandwidth could you add a PR for discussion?

from workflow-execution-service-schemas.

uniqueg avatar uniqueg commented on June 9, 2024

For reference, there is a PR for filtering list outputs in TES as well: ga4gh/task-execution-schemas#170
Requirements and use cases should be almost identical

from workflow-execution-service-schemas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.