Giter Site home page Giter Site logo

Comments (8)

mckinsel avatar mckinsel commented on June 9, 2024

The changes don't seem to be too huge. The biggest benefit would probably be that we could correctly specify an arbitrary number of files to upload for workflow_descriptor.

For me, the biggest drawback is that there seems to be less tooling for openapi 3. For example, AWS API Gateway doesn't appear to work with it.

from workflow-execution-service-schemas.

denis-yuen avatar denis-yuen commented on June 9, 2024

Same here, we've been poking around at OpenAPI 3, but swagger-codegen is almost but not quite ready for compatibility. https://github.com/swagger-api/swagger-codegen#compatibility

from workflow-execution-service-schemas.

jaeddy avatar jaeddy commented on June 9, 2024

See (and track) ga4gh/data-repository-service-schemas#230

from workflow-execution-service-schemas.

brainstorm avatar brainstorm commented on June 9, 2024

@denis-yuen See ga4gh/data-repository-service-schemas#230 (comment), hope that helps, it worked for me with htsget and Rust:

openapi-generator generate -i spec/htsget-openapi.yaml -g rust -o src/htsget-client
openapi-generator generate -i spec/htsget-openapi.yaml -g rust-server -o src/htsget-server

(After brew install openapi-generator, that is).

from workflow-execution-service-schemas.

jaeddy avatar jaeddy commented on June 9, 2024

Thanks, @brainstorm! I'll check that out.

@wshands— can you provide some detail for the code-gen client failures you've observed for OpenAPI 2.0 and 3.0?

from workflow-execution-service-schemas.

wshands avatar wshands commented on June 9, 2024

The error I saw was that contents of the files in the workflow attachment are not included in a POST request and seems to occur in both the Swagger and OpenApi code generators. I submitted these two issues:
swagger-api/swagger-codegen#9195
OpenAPITools/openapi-generator#2210

from workflow-execution-service-schemas.

denis-yuen avatar denis-yuen commented on June 9, 2024

@brainstorm thanks for the tip, in a different issue much later we found that swagger-codegen 3.0.4 also works ga4gh/data-repository-service-schemas#230 (comment)

from workflow-execution-service-schemas.

patmagee avatar patmagee commented on June 9, 2024

Closing this as it looks like our API spec is currently on v 3.0

from workflow-execution-service-schemas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.