Comments (7)
@gabek could these be SVG?
from gityourfeedback.
@qbunt Good question, but sadly no. They need to be supported natively by iOS and the asset catalog. But PDF is a good option since one size can be provided and all of the resolutions will be generated at build time.
Here's a good overview on using PDFs with image sets. https://icons8.com/articles/how-to-use-vectors-in-xcode-7/
from gityourfeedback.
@gabek I'd be happy to get you the appropriate icon set based on Google's material design. Three sizes per icon?
from gityourfeedback.
@noahfeder Awesome! Three sizes (The base size, @2x, and @3x). The alternative is one image that's a PDF and Xcode creates the three images at build time. It's a handy alternative.
While I think Google's material design looks great, it is very Android distinctive. iOS icons are often a little thinner and less often filled in. I found a nice comparison here: https://blog.dropsource.com/whats-different-when-designing-apps-for-ios-or-android-99648738206b#.kmnb3gtgb (scroll to the Icons
section).
Are you able to get the project up and running to test the new icons and see how they look? I'm happy to help.
from gityourfeedback.
Sorry for the slow response. I'm new-ish to XCode, having only really used it for a React Native project, so this error is throwing me for a loop when I try to build/run the Example app.
Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
from gityourfeedback.
@noahfeder Oh no! Hopefully we can figure this out.
Make sure you're on Xcode 8.0, as that has the implementation of Swift 3 that we require to run the project.
Are you able to pod install
from the Example
directory?
from gityourfeedback.
Thanks for taking care of this, @funky-monkey!
from gityourfeedback.
Related Issues (20)
- Verify that image library permissions are being asked for properly HOT 1
- Crash in FeedbackInterfaceViewController HOT 1
- Easy!: Create animated GIF of the project in use HOT 4
- Throw an error if the .datasource property is not set
- Use the GitHub Collapsible Content Markdown feature to hide details
- Create an out-of-the-box struct that implements FeedbackOptions
- Request: Submit feedback in the background
- Text field resizing: Make it less janky
- Request: Is it possible/useful to put placeholder text of "Description optional" in the body? HOT 1
- Release v0.1.1
- Pass in the delegate in the initializer
- Combine View and Edit into one option
- Reduce screenshot size more
- Add inline documentation
- Adapt to work with Swift 2.3 & minimum iOS 8 HOT 3
- iOS 11: Investigate the new screenshot functionality HOT 3
- Add S3 storage support.
- Fix crash on launch for demo project (iOS 11) HOT 3
- Update to Swift 4.x HOT 4
- HTTP Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gityourfeedback.