Refactor lettuce.plugins.shell_output and lettuce.plugins.colored_shell_output

[gabrielfalcao]

Refactor lettuce.plugins.shell_output and lettuce.plugins.colored_shell_output

[bluemoon]

You could go as far as something like this:

class NullStream:
    def write(self, text):
        pass

import sys
sys.stdout = NullStream()

[gabrielfalcao]

Actually, the feature I'm thinking to implement on couleur is pretty much it :)
Thanks

[rudylattae]

My 2 pesos:

Please consider the fact that the Winblows shell (aka dos prompt) does not understand *nix color codes. I got lettuce installed and fired it up and guess what I saw... the cryptic stuff below!

←[1;31mOops!←[0m
←[1;37mcould not find features at ←[1;33m\features←[0m

I quickly jumped into cygwin (the poor-man's *nix on Winblows) and saw a nicely colored output saying:

Oops!
could not find features at ./features

The "Oops!" was in red. The "could not find..." was bright white and the "./features" was in yellow. The garbled message I got in the dos shell earlier was just a nicely colored output -- visible only in a *nix shell.

Digging through the code I noticed that lettuce uses plugins to handle output -- AWESOME! On a Win machine the only solution is to just spit stuff out without any color codes. From what I saw in the lettuce code, it selects the output handler based on the verbosity level passed in:

-v VERBOSITY, --verbosity=VERBOSITY

So if I run lettuce with a verbosity level of 0, it loads the non_verbose plugin. If I run it with a verbosity level of 3, it loads the shell_output plugin. Both these plugins output straight text without any coloring. Any other verbosity level (and if no level is specified), the output is handled by the colored_shell_output plugin.

I'm sure by now you can see that the only way for a poor Winblows developer like myself to get any real benefit out of lettuce is to pass it a verbosity level "3". If the shell_output plugin is "improved" to always output in color the Python-Winblows universe may very well collapse in on itself! Ok, ok, I guess that's an exaggeration but you get my point.

So Gaberiel, my suggestion is that if you want to implement color support for verbosity level 3 (and I think that is a good thing), please consider implementing such that it can be turned on/off as needed. In fact a very good pattern for the color feature is to make it possible to toggle it independently of the verbosity level.

Thanks and keep up the awesome work.

[gabrielfalcao]

I'm gonna make couleur support windows

[gabrielfalcao]

shell output using couleur, closed by 8894b9d