Giter Site home page Giter Site logo

Comments (7)

gabrielmbmb avatar gabrielmbmb commented on September 5, 2024

Hi @ttntm. I haven't checked if Vuex has suffered any relevant change in Vue 3 or Vue 4 that breaks the plugin or makes it work badly. I will check it!

from vuex-multi-tab-state.

ttntm avatar ttntm commented on September 5, 2024

Thanks! If it helps, I was using Brave Version 1.12.105 Chromium: 84.0.4147.105 (Official Build) on Manjaro Linux (64-bit) when I encountered this potential issue.

Once commented out, it all worked fine (except for multi tab state of course...). No idea what might be causing this, but it felt like some sort of endless loop or some other infinite operation was going on filling up the CPU and destroying the browser.

No errors showed up in the Console btw. - I haven't had a look at it with a debugger, but I could do that if you can't find anything -- just let me know.

from vuex-multi-tab-state.

gabrielmbmb avatar gabrielmbmb commented on September 5, 2024

Hey! I've been checking the plugin with Vue 3 and I couldn't detect any failure or any increment on the CPU workload. Could you provide me more info? Like the kind of state you are trying to keep synced (object, array, ...)

from vuex-multi-tab-state.

ttntm avatar ttntm commented on September 5, 2024

Thanks for looking into it.

Here's my app's store: https://github.com/ttntm/watchlist/tree/master/src/store

It's module based and the action that I noticed problems with is called attemptLogout - you can have a look at it here

I'm using the same user authentication logic in a Vue 2 app together with your plugin and it works flawlessly.

I'll see if I can get any more info re: what's happening at runtime and I'll also test in some other browsers.

from vuex-multi-tab-state.

gabrielmbmb avatar gabrielmbmb commented on September 5, 2024

I was suspicious of setting the value to null, but I checked it and that's not the problem

from vuex-multi-tab-state.

ttntm avatar ttntm commented on September 5, 2024

Thanks for the responsiveness, I had your plugin uninstalled for production deployment some days ago, that's why it's not there.

I'm currently working with the Chromium's and Firefox's respective debuggers and I've already found (and fixed) the infinite loop. It was an onBeforeUpdate Vue 3 hook that was causing a sorting function to freak out - one tab sorted the array, the other one got the updated array from your plugin and sorted it again and so on.

I'm still struggling with some weird behaviour on logout, but I'm rather sure your plugin is not the cause of it (or any issues for that matter) - it seems to do it's job well and I'm sorry for suggesting it didn't.

from vuex-multi-tab-state.

gabrielmbmb avatar gabrielmbmb commented on September 5, 2024

No problem!

from vuex-multi-tab-state.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.