gaetanopiazzolla/layer3gen

Easy Auto Generating the SPRING 3 layer architecture ( Controller-Service-Repository) from JPA Entities

layer3gen's Issues

Issue generating correct repository key tpye

An issue in generating a repository class using the latest version. I have below table in MySQL.
CREATE TABLE contacts (
CONTACT_ID smallint(6) NOT NULL,
DESCR varchar(100) DEFAULT NULL,
PRIMARY KEY (CONTACT_ID)
) ENGINE=InnoDB DEFAULT CHARSET=utf8.

The repository generated as below
public interface ContactModesRepository extends JpaRepository<ContactModes, java.lang.String> {
}

I think the repository should have a key as java.lang.Short, instead it's generated as java.lang.String.

I'm observing similar issue across other tables, For example the entity class have value as java.lang.Long, but repository class key is java.lang.String.

Please help here.

Some enhancements and suggestions

First of all let me praising and appreciate the effort done in this amazing plugin, here are some points that I believe it will make it more awesome :

• Adding options to generate ControllersDto only or with Controller using entity, as best and common practices, most of developers don't want to expose their entity/db schema in public. (Yaml configuration)
• Adding options to generate the CrudController Interface or not (Yaml configuration).
• Adding options to generate the CrudService Interface or not (Yaml configuration).
• Adding options to specify the dto location package.
• Adding options to specify the mapper location package.
• Adding documentation to ensure build project first before running the plugin command. or just update the command to be ./gradlew clean build layer3gen
• In CrudController all read operation should be in get verb(common convention), but I found @PostMapping("find") and also passing the entity itself, I don't have any clue what is the use for this entity. Pageable rest api, should only take the page and size parameters, also to mention findAll method not need to pass the example, Example<User> example = Example.of(entity); you can just say repository.findAll(pageable); without passing example object.
• In generated dto found two not needed imports
• import org.springframework.data.domain.Page; mport org.springframework.data.domain.Pageable;
• In readOne, in service layer, repository.getOne(primaryKey); getOne is deprecated method and will be removed soon, instead use findById and return Optional object is more common.