gaigresearch/tribes

Tribes is an open source implementation for AI research of the game The Battle of Polytopia

tribes's Issues

vector vs x,y

Converge to Vector2d

Action Pack A

• Attack (unit action)
• Capture (unit action)
• Convert (unit action)
• Resource Gathering (city action)

Refactor unit creation

Creation of units requieres several calls now. Need to find an easier way.

Converted Units #2

Move from objects to unit ids
Also another name for the variable. It contains converted units, but also those derived from unit shifts.

Monuments

Tribes should manage monuments counters. Actions should be created accordingly.

GUI: Examine and Capture actions not showing up in the interface

but they're added to the available array

Actions Coordinates Bounds Check

All actions should be checking bounds on any positions (e.g. neighbours) they're considering and querying the grid for (>=0 and <gridSize). Currently some crash if units move to the edges.

E.g. AttackFactory.computeActionVariants() method has a loop that checks neighbouring cells, but those coordinates are not validated to be within the grid. Likely to be the case in others as well.

// Loop through unit range, check if tile observable and action feasible, if so add action
        for(int i = position.x - unit.RANGE; i <= position.x + unit.RANGE; i++) {
            for (int j = position.y - unit.RANGE; j <= position.y + unit.RANGE; j++) {
                //Not attacking itself
                if(i != position.x || j != position.y) {

                    Attack a = new Attack(unit.getActorId());
                    Unit other = b.getUnitAt(i, j);
                    if (other != null) {  // Check if there is actually a unit there
                        a.setTargetId(other.getActorId());
                        if (a.isFeasible(gs)) {
                            attacks.add(a);
                        }
                    }
                }
            }
        }

Converted units

Units that join a tribe via the Convert action do not count as population for any city. That also means that we're not adding them to any city, so they're lost in time and space - we can't access them from a Tribe. We need to hold those unit ids somewhere (maybe Tribe)?

Actions per unit

Different units can do different combinations of actions, depending on the attack results. This is not implemented now (manage it using Types.TURN_STATUS).

See the possibilities here: https://github.com/GAIGResearch/Tribes/wiki/Actions

Actual Turn Ending

• Turn end action
• remove turn change by time for human players

Meeting a tribe

Meeting a tribe for the first time grants knowledge of a technology. I'm not sure if the fandom says how does this happen...

GUI Tooltips

Actions should describe effects & requirements.

GUI: in a small monitor, the frame size/distribution doesn't show the level map

Check for game over

After every action, in GameState.next(), check of the game is over

Star generation

Star generation at the beginning of each turn needs to be computed.
Note that, if enemy unit is in an owned city, that city does not generate stars that turn.

Action lists copied in GameState.copy()

GameState.copy() missing a deep copy on the actions lists, otherwise they're not actually received by the players/GUI. Those lists are possibly affected by the actions refactor too?

Resource Gathering

Resources need to disappear from the board when collected.

Trade Network Computation

Still to be computed. See Tribe.updateNetwork(...).

Board.getCityTiles() performace

At the moment, this method runs through the whole board to check tiles that rarely change. Add a list of tiles to City.java (ArrayList, order doesn't matter) that is updated with the calls to Board.setBorderHelper() and access through that list instead.

Preferred: same method, different limits (not size, but position+-RANGE)

Handle turn change

Needs two parts:

• Move the current turn (GameState.activeTribeID) to the next tribe.
• Compute the starting turn events: star provision and score update

Note that, if enemy unit is in an owned city, that city does not generate stars that turn.

Vector2d vs (targetX, targetY) in CityAction

Use vector2d instead

[UPDATE] UNITS shifts

When a new city is captured (from a village to city), one UNIT moves there from the capital.

If capital has UNIT == 0, then it's taken from another city (at random?)

Attack action

The attacking unit gets damage back from the target if the target is not killed. This is not happening now in the Attack action.

Also, in some cases (when the attacker is not a ranged unit), the attacker takes the position of the target if the target is killed.

GUI: Show tribe stars all the time, not int tab

Terrain visibility

Some terrain is only visible for a tribe when a certain tech is researched:

• Climbing reveals ore in the mountains: https://polytopia.fandom.com/wiki/Climbing
• Fishing reveals Whales: https://polytopia.fandom.com/wiki/Fishing
• Organization reveals Crop: https://polytopia.fandom.com/wiki/Organization

+5 points for each tile discovered

also, +20 points for every non-city tile added to the tribe's territory. This means that converting village into city means 180 points (100 for city level 1 + 8x20 tiles around for borders). Level Up - Border_growth also adds +20 for all the new tiles.

Actor ID errors

Current codebase version gives a lot of exceptions everywhere where a list of actors and actor IDs are used, and possibly more - it seems a lot of these IDs are lost at some point, maybe not copied?

Also, do tribes need actor IDs? I can't think of a case where the tribe would be retrieved by actor ID instead of tribe ID.

E.g.

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -1
at core.game.Game.initTurn(Game.java:273)
at core.game.Game.processTurn(Game.java:211)
at core.game.Game.tick(Game.java:189)
at core.game.Game.run(Game.java:164)
at Run.runGame(Run.java:28)
at Play.main(Play.java:46)

Exception in thread "main" java.lang.NullPointerException
at core.actions.cityactions.LevelUp.isFeasible(LevelUp.java:34)
at core.actions.cityactions.factory.LevelUpFactory.computeActionVariants(LevelUpFactory.java:24)
at core.actions.cityactions.factory.CityActionBuilder.getActions(CityActionBuilder.java:23)
at core.game.GameState.computePlayerActions(GameState.java:160)
at core.game.Game.initTurn(Game.java:315)
at core.game.Game.processTurn(Game.java:211)
at core.game.Game.tick(Game.java:189)
at core.game.Game.run(Game.java:164)
at Run.runGame(Run.java:28)
at Play.main(Play.java:46)

Boats, Ships and Battleships

We've somehow forgotten about naval units (Boat, Ship and Battleship). They were missing in the Types enum, sprites and we don't have classes for them.

I added them to Types and found the sprite sets for them. Stavros, can you please add the classes to the corresponding package? (there are no dependencies, they can be added to the refactor-2 branch). Sprites and types are now merged into master.

Actions refactor

Mind Bender can't move into an enemy city tile

I wasn't aware of this... Mind bender must not be able to move into a city tile

Action Pack B

• Move (unit action)
• Heal Others (unit action)
• Upgrade (unit action)
• Build (city action)

Uses of Random

All random events in the game must come from a common Random object (which uses a determined random seed).

Altar of Peace

No computation for this monument yet - https://polytopia.fandom.com/wiki/Altar_of_Peace

City Issues

If an enemy unit or Nature Bunny moves into one of your cities, star production from that city will stop entirely and you will gain 0 stars from it the next turn. City Class

Units in their tribe's city get a +50% (×1.5) defence buff, which increases to +300% (×4) if the city has city walls. Defense Action

It is also important to note that the amount of cities you own influences the prices of tech on the Technology Tree. 1 star per extra city for Tier 1, 2 stars per extra city on Tier 2 and 3 stars on Tier 3 techs. Technology Action

Tribe.meetTribe() is never called

Refactoring in buildings

There are two main things that can be refactored in the buildings hierarchy:

1. There are some variables that are common to many buildings (example: cost) that can be in the upper class (Building) and not in the derivate. In fact, probably most of them are (production, type, even the constraints). We can set void values (null, or 0) to those units that do not have production, for instance. The same is true with the accessor functions (getType(), for instance, but also others).

2. The actual (constant) values for different properties of buildings should be extracted to a common file. I've created TribesConfig.java for this (check this in the branch refactor-2). The best way would be to pass this values in the class constructor - I've made an example of this for Warrior.java, in refactor-2 branch).

And two extra things that may help simplify things:

3. All monuments (TowerOfWisdom, ParkOfFortune, etc.) are essentially the same, so we could probably converge them all in a single class Monument.java and remove the other ones.

4. Doesn't the same concept above in (3) applies to the different types of Temples in the game.

Overall, the concept is to move to a more data-driven approach. Less classes/code and more reliance on parameter values.

Note that in the branch refactor-2 I've also made a refactoring of files and packages below 'units' (now called 'actors', to reflect its meaning better).

Negative populations

Populations can be negative in cities, which happens when losing connection to the capital. But I'm not 100% sure how it happens, so needs investigating.

One clear effect is that a city with -X population generates -X stars.

"Something" (apart from temples) generates score for a tribe at the beginning of each turn

Find out what it is and implement it

Action Pack C

• Examine (unit action)
• Spawn (city action)
• Clear Forest (city action)
• Grow Forest (city action)
• Burn Forest (city action)
• Destroy (city action)

Savegames

We need functionality to saving/loading gamestates. Ideally in a human readable format (i.e. JSON).

City.java using clone()

One thing we need to avoid using is clone() - I may have forgotten mentioning this.

We need to create our own copy method for the objects, as clone() has shown unstable behaviour. This is specially true for objects contained in data structures.

One action is missing...

Build Road! See also this: https://polytopia.fandom.com/wiki/City_Connections

Constants extraction from Units

All constant values (properties of units) should be extracted to a common file: TribesConfig.java

• I've made this with Warrior.java as an example.

Check this in the branch refactor-2
Note that in this branch there's also a refactoring of files and packages below 'units' (now 'actors', to reflect its meaning better).

Handle Unit Status

• analyze transition code
• init at start of turn
• call from all appropriate actions

Action Pack D

• Actions upgrade level 2
• Actions upgrade level 3
• Actions upgrade level 4
• Actions upgrade level 5+
• End Turn Action

Destroying a Custom House

Destry.java, execute()

When destroying a CUSTOM HOUSE building, see:

//TODO: Is this correct? The production of a custom house depends on the number of Ports around it,
// so I'm not sure this should be a constant value.

city.subtractProduction(removedBuilding.getPRODUCTION());

Resources that can't be resourced

• Ore can't be gathered. Instead, a mine can be built when there's an Ore resource.
• Crops can't be gathered. Instead, a farm can be built when there's a Crops resource.

I've removed these options from the ResourceGathering.execute() methods, but I wonder if the mine and farm building are taking the added production into account.

Building checks

BUILDING

• Check if types are actually assigned to building classes
• Use constants from Types.BUILDING (instead of TribesConfig)
• Make sure all the side effects for Buildings are counted.

CUSTOM HOUSE

• isBuildable(): it must check if there's at least 1 port adjacent to it. Otherwise it can't be built.

• New method in CustomHouse: computeProduction(c, gs) -> computes and returns the production of this custom house.

Custom House will have its own production that is not added to the city. That way it's easier to ignore this production when destroyed.

FORGE, SAWMIMLL

• Check adjacency conditions for these buildings

Board.occupy(...)

This function needs changing. A village is not a City object, but a terrain type.
Needs to manage two cases:

• When the city belongs to another player.
• When it's occupying a village, not a city.

Points for spawning units

Spawning units gives points to the tribe. I haven't seen when in the wiki is this reflected, but it does happen. Also Disband removes these points from the tribe.