Giter Site home page Giter Site logo

Comments (8)

shaharmor avatar shaharmor commented on May 31, 2024

Maybe you should put a note about it in the README.. would have saved me some time 😄

from redis-memory-analyzer.

misterion avatar misterion commented on May 31, 2024

We do not use redis cluster right now, so i do not know this not working with it. From stacktrace i see this can be fast fixed with some perfomance breakdown. So i tnink i fix it during this week.

from redis-memory-analyzer.

shaharmor avatar shaharmor commented on May 31, 2024

Ok thnx, let me know when you have and i'll give it a shot

from redis-memory-analyzer.

misterion avatar misterion commented on May 31, 2024

@shaharmor how do you see cluster report? It is per node report or full cluster? Now i fix original issue, but as i see redis-py can`t work with MOVE responses. So i want to understang how to it in right way. If you need node stat i can just skip keys from node which actually not on this node.

from redis-memory-analyzer.

shaharmor avatar shaharmor commented on May 31, 2024

@misterion - I tried running it right now with latest version.
Its running and looks like its going over all keys (In the specified node i connected it to), but the report doesn't show anything other than the global stats. (Just empty tables).

I don't expect the report to be of the full cluster (Although that would be awesome), but just for the node i connected to.

When you use SCAN on the node itself, its going only over the keys in that node (Not in the entire cluster), so it shouldn't be a change from what you do today.

But for some reason there is no output for the keys it scanned.

from redis-memory-analyzer.

misterion avatar misterion commented on May 31, 2024

I still working under it. From time to time node ask to MOVE to other node to execute command for key returned by SCAN. Now my devops moves one of out redis test server to cluster to test all of this in live cluster server. Playing now with redis-py-cluster library - looks like this should work fine as in cluster as in single mode.

from redis-memory-analyzer.

misterion avatar misterion commented on May 31, 2024

Now waiting resposne with Grokzen/redis-py-cluster#123. Looks like this library has a bug with MOVED response :(

from redis-memory-analyzer.

misterion avatar misterion commented on May 31, 2024

The issue from redis-py-cluster was fixed in unstable branch according to the contributors comments. I check it with my dev cluster and still have MOVE fails with it. So want to check why this so and help to improve redis-py-cluster to fix this. I have working workaround to hack fix this but this patch could be used in production becouse based on reACK on each MOVE error. In this case scanning takes absolutely unreal time.

from redis-memory-analyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.