Giter Site home page Giter Site logo

Comments (5)

criemen avatar criemen commented on July 24, 2024

Thanks for the fast fix on #86 and the turnaround time, but I can't see how the commit fixes this issue.
What I asked for was a switch to turn of the cluster prefix, either globally or for sending the data to graphite.
Maybe this is already implemented and I overlooked it, and this is the
if (source) {
part of the code, I think it is still wrong, because without a graphite_prefix and without a source, you'll still access an unitialiued graphite_msg when adding the host ti graphite_msg.

from monitor-core.

vvuksan avatar vvuksan commented on July 24, 2024

This was errantly closed. Previous fix was just for #86.

from monitor-core.

djosephsen avatar djosephsen commented on July 24, 2024

Noticed this didn't get fixed at monitorama, so I put in a pull request that will allow you to do whatever you want with the graphite path, to include omitting whatever parts make sense. (#99).

From the new gmetad.conf:

A user-definable graphite path. Graphite uses dot-separated paths to organize and refer to metrics. For reverse compatibility graphite_prefix will be prepended to this path, but this behavior should be considered deprecated.
This path may include 3 variables that will be replaced accordingly:
%s -> source (cluster name)
%h -> host (host name)
%m -> metric (metric name)
default: graphite_prefix.%s.%h.%m
graphite_path "datacenter1.gmetad.%s.%h.%m

from monitor-core.

djosephsen avatar djosephsen commented on July 24, 2024

so we can close this yeah?

from monitor-core.

criemen avatar criemen commented on July 24, 2024

I believe so, yes.
Thanks for your effort!

from monitor-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.