Comments (3)
Another thing - we also don't currently pick up new modules when they're added.
It occurs to me that we should perhaps change a bit how we handle file watching. Instead of putting multiple explicit watches on individual directories, that we should watch all source directories and then filter and route events as they occur. @thsig did you explore that when you wrote the watcher logic?
from garden.
I thought of that possibility, but back then, I didn't think of the case when module/project config, so I chose the simpler implementation for starters (since there's no need for filtering/routing for per-module watches).
I agree we should make the change you outline above to the file watching logic, i.e. using a single project-wide watch, where change notifications trigger reloads of the appropriate modules (if any), and where processModules
is restarted when that's called for.
The file watching part of it, at least, should be fairly straightforward.
from garden.
Fixed here: #157
from garden.
Related Issues (20)
- 0.13: [Bug]: Jib Container picks a wrong deployment image id while building images HOT 4
- 0.13: [Bug]: --skip-dependencies is not working correctly with garden plugins pulumi preview command HOT 4
- [FEATURE]: replacing image when sync
- Add Pulumi 3.102.0 to fix vulnerability in pulumi deps
- Remove conftest HOT 1
- Update Helm to 3.15.2
- Includes not automatically set on Helm actions that reference remote charts
- 0.13: [Bug]: npm ci missing from garden plugins pulumi preview command HOT 6
- Crash: Garden crashes on I/O errors while artifacts copying HOT 1
- [Bug]: Action scan misbehaviour?
- [Bug]: exec run logs duplicate in verbose loglevel
- [FEATURE]: Support env variable to avoid running `garden util hide-warning web-app` HOT 2
- [FEATURE]: CLI command to list all actions HOT 4
- [FEATURE]: Module as job / cronjob in kubernetes HOT 2
- crashing with SYNCHRONOUS TERMINATION NOTICE error HOT 2
- Crash: toKubernetesError encountered an unknown error during Kubernetes API: HOT 10
- [FEATURE]: Support a Nix Derivation based OCI image builder much like Kaniko is for Dockerfiles HOT 6
- Crash: Synchronization monitor has crashed 10 times. Aborting HOT 2
- [Bug]: Custom Commands Not Working HOT 2
- Garden 0.13 crashes if K8s token expired HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from garden.