Giter Site home page Giter Site logo

Comments (3)

edvald avatar edvald commented on September 13, 2024

Another thing - we also don't currently pick up new modules when they're added.

It occurs to me that we should perhaps change a bit how we handle file watching. Instead of putting multiple explicit watches on individual directories, that we should watch all source directories and then filter and route events as they occur. @thsig did you explore that when you wrote the watcher logic?

from garden.

thsig avatar thsig commented on September 13, 2024

I thought of that possibility, but back then, I didn't think of the case when module/project config, so I chose the simpler implementation for starters (since there's no need for filtering/routing for per-module watches).

I agree we should make the change you outline above to the file watching logic, i.e. using a single project-wide watch, where change notifications trigger reloads of the appropriate modules (if any), and where processModules is restarted when that's called for.

The file watching part of it, at least, should be fairly straightforward.

from garden.

thsig avatar thsig commented on September 13, 2024

Fixed here: #157

from garden.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.