Giter Site home page Giter Site logo

Comments (4)

rfranzke avatar rfranzke commented on July 17, 2024 1

Yeah, using PATCH makes sense.

Still, I'm not sure, why grm didn't retry the reconciliation...

Same here, I still need to try to reproduce it. As said yesterday, it might also be the case that it "just" was in an exponential backoff and would have retried if I would have waited longer.

from gardener-resource-manager.

timebertt avatar timebertt commented on July 17, 2024

Hmm, not sure if this solves the issue, but we should switch to patching finalizers and using the c-r helper funcs like here:
https://github.com/gardener/gardener/blob/9af2e8a04a08cb78c66bbdc0ab47af577c5b28d2/pkg/controllerutils/finalizers.go#L35-L55

Still, I'm not sure, why grm didn't retry the reconciliation...

from gardener-resource-manager.

ialidzhikov avatar ialidzhikov commented on July 17, 2024

I also had a short look and currently I don't see any obvious reason. For @timebertt 's suggestion in #78 (comment) -> #87.

from gardener-resource-manager.

rfranzke avatar rfranzke commented on July 17, 2024

OK, thanks @ialidzhikov, then let's
/close
this issue for now as there are no clear steps for reproduction anyways and as I wasn't sure whether it's just exponential backoff.
#87 is merged and will definitely help.
In case we see this problem again we can reopen the issue, of course.

from gardener-resource-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.