Comments (4)
Yeah, using PATCH makes sense.
Still, I'm not sure, why grm didn't retry the reconciliation...
Same here, I still need to try to reproduce it. As said yesterday, it might also be the case that it "just" was in an exponential backoff and would have retried if I would have waited longer.
from gardener-resource-manager.
Hmm, not sure if this solves the issue, but we should switch to patching finalizers and using the c-r helper funcs like here:
https://github.com/gardener/gardener/blob/9af2e8a04a08cb78c66bbdc0ab47af577c5b28d2/pkg/controllerutils/finalizers.go#L35-L55
Still, I'm not sure, why grm didn't retry the reconciliation...
from gardener-resource-manager.
I also had a short look and currently I don't see any obvious reason. For @timebertt 's suggestion in #78 (comment) -> #87.
from gardener-resource-manager.
OK, thanks @ialidzhikov, then let's
/close
this issue for now as there are no clear steps for reproduction anyways and as I wasn't sure whether it's just exponential backoff.
#87 is merged and will definitely help.
In case we see this problem again we can reopen the issue, of course.
from gardener-resource-manager.
Related Issues (20)
- Add annotations for source of generated resources
- Garbage Collector for immutable `ConfigMap`s/`Secret`s which are no longer in-use HOT 26
- spec.loadBalancerIP field of Service resource with type: LoadBalancer gets discarded HOT 11
- ManagedResource reconciliation takes more than 20m when APIService in unavailable HOT 10
- Cannot update the container image of batch/v1 Job HOT 6
- managedresource stuck in deletion HOT 1
- Service with externalTrafficPolicy=Local can't be updated
- Finalizer is not removed from secret HOT 1
- `status` of `VerticalPodAutoscaler` objects is not kept HOT 3
- Failing health checks for `APIService` HOT 1
- `foregroundDeletion` finalizer blocks deletion HOT 2
- Services deletion blocked HOT 1
- Service ClusterIP is ignored
- Switch leader election to lease HOT 4
- /healthz endpoint for liveness probe
- Improve CheckDaemonSet func HOT 2
- Add option to disable target cache HOT 3
- Switch to DynamicRESTMapper for target client HOT 1
- Worker routines get stuck HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gardener-resource-manager.