[BUG] Fix reconciliation predicates to fully comply with gardener extension contract

[amshuman-kr]

[BUG] Fix reconciliation predicates to fully comply with gardener extension contract

[shreyas-s-rao]

@amshuman-kr from the extension contract, I see that They have to remove this annotation as soon as they begin with their reconcile operation and maintain the status of the extension resource accordingly. Whereas, in the druid controller, we actually remove the operation annotation after performing the reconciliation, while updating the etcd status (refer). This behavior has to be changed as well right?

[amshuman-kr]

Thanks for the review @shreyas-s-rao! AFAIK, the important bit is to make sure the spec reconciliation happens only when the annotation exists. If we remove the annotation at the beginning or end of reconciliation doesn't much affect the contract.

We can still do the change to move the removal of the annotation earlier in the reconciliation, but I would suggests let's pick this after multi-node. WDYT?

[shreyas-s-rao]

Sounds good @amshuman-kr . Just saw the deviation from ideal behavior so raised it here.

[shreyas-s-rao]

I've raised an issue for it here -> #204