Giter Site home page Giter Site logo

Comments (6)

ialidzhikov avatar ialidzhikov commented on July 18, 2024 1

I think we should make changes to make possible from the ConfigValidator to return provider related error such as ERR_INFRA_UNAUTHENTICATED and ERR_INFRA_UNAUTHORIZED. The reason to introduce the ConfigValidator interface was to perform prerequisite checks before the Infrastructure reconciliation - for example make sure the VPC exists, and has the needed fields enabled; make sure the Network exists, etc. Usually the ConfigValidator create a client, get the cloud provider resource and then check it. So, this get operation is the first operation that is executed with the Shoot's cloud provider credentials and that can fail due to invalid credentials. To improve the ops productivity we should rather think about how to make possible the error categorization in that case.

from gardener-extension-provider-openstack.

ialidzhikov avatar ialidzhikov commented on July 18, 2024

/cc @acumino

from gardener-extension-provider-openstack.

kon-angelo avatar kon-angelo commented on July 18, 2024

@ialidzhikov I think the error for this is coming from ConfigValidator so this is probably not easily fixed in the extension if I am not mistaken

from gardener-extension-provider-openstack.

acumino avatar acumino commented on July 18, 2024

/assign

from gardener-extension-provider-openstack.

acumino avatar acumino commented on July 18, 2024

The error from configValidator is supposed to be considered only for configuration error and that is already being checked here.
We can consider other error codes also for configValidator error by putting error code check here. But this is not being done in any provider extension. So I would propose to close this issues.

from gardener-extension-provider-openstack.

acumino avatar acumino commented on July 18, 2024

/close
Fixed by #745

from gardener-extension-provider-openstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.