Comments (6)
I think we should make changes to make possible from the ConfigValidator to return provider related error such as ERR_INFRA_UNAUTHENTICATED
and ERR_INFRA_UNAUTHORIZED
. The reason to introduce the ConfigValidator interface was to perform prerequisite checks before the Infrastructure reconciliation - for example make sure the VPC exists, and has the needed fields enabled; make sure the Network exists, etc. Usually the ConfigValidator create a client, get the cloud provider resource and then check it. So, this get operation is the first operation that is executed with the Shoot's cloud provider credentials and that can fail due to invalid credentials. To improve the ops productivity we should rather think about how to make possible the error categorization in that case.
from gardener-extension-provider-openstack.
/cc @acumino
from gardener-extension-provider-openstack.
@ialidzhikov I think the error for this is coming from ConfigValidator so this is probably not easily fixed in the extension if I am not mistaken
from gardener-extension-provider-openstack.
/assign
from gardener-extension-provider-openstack.
The error from configValidator is supposed to be considered only for configuration error and that is already being checked here.
We can consider other error codes also for configValidator error by putting error code check here. But this is not being done in any provider extension. So I would propose to close this issues.
from gardener-extension-provider-openstack.
/close
Fixed by #745
from gardener-extension-provider-openstack.
Related Issues (20)
- Managed application credentials
- GPU support of bare metal machines HOT 4
- Seed cluster cannot recover after failed reconciliation when trying to delete network resources HOT 5
- Avoid disruptive changes to Shoot ETCD
- `make integration-test-infra` fails HOT 3
- Validation for pod and node cidr ranges if the same router id is used
- `snapshot.storage.k8s.io` CRDs flapping HOT 1
- Shoot worker node hostname changes after machine reboot
- Add support for new OCCM cloud provider options
- Allow configuration of NodeTemplate for Autoscaler by user
- Error code not added HOT 3
- subnetID not set when creating a floating IP for the bastion vm HOT 1
- Shoot migration fails while using server group
- Support multiple NICs for shoot nodes HOT 1
- Support for enabling share networks is missing in the Flow-based infrastructure reconciliation without Terraformer
- "Clean leftover kubernetes loadbalancers" (#656) is a breaking change on our environment HOT 2
- Error --webhook-config-mode
- Parse user errors log and set the user error code in the ControlPlaneHealthy health check to minimize user related VictorOps alerts HOT 1
- Remove useOctavia setting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gardener-extension-provider-openstack.