Comments (5)
That may comes from me.
I agree that a coding standard would be great.
Also a bit of doc about some of the design philosophy would help as well. (Mostly about layouting)
What about activating the wiki ?
from gwen.
Coding standards would be good to set the formatting in stone. But could we please have formatting that looks like other C++. If GWEN is going to be constantly reformatted, I may just fork it, or find another solution.
I work on a laptop a lot (13" screen) so I like space saving "narrower" code. Line length max 100?
Can we please avoid idomatic formatting (which also confuses editors because the brackets don't match):
if ( foo == 7 )
{ doSomething(); }
One of:
if ( foo == 7 ) { doSomething(); }
if ( foo == 7 ) {
doSomething();
}
if ( foo == 7 )
{
doSomething();
}
And there is nothing wrong with:
if ( foo == 7 )
doSomething();
or:
switch ( test ) // This is easier to read on a 13" laptop, and easier to see all values
{
case A: value = 1; break;
case B: value = 2; break;
case C: value = 3; break;
case D: value = 4; break;
}
not:
switch ( test )
{
case A:
value = 1;
break;
case B:
value = 2;
break;
case C:
value = 3;
break;
case D:
value = 4;
break;
}
from gwen.
Also, there seem to be quite a few warnings in the code (signed/unsigned, _s etc). I think these are priority over fixing the formatting.
from gwen.
Well, at this stage, it would be great to have a feedback from Garry :)
We should try not to be emotional about decision and keep it friendly.
But we need to have decision ... (Hi Garry !)
from gwen.
I thought the code formatting was pretty obvious from looking at all of the other existing code. ie lots of spacing, no Egyption bracketing etc.
from gwen.
Related Issues (20)
- Problem with TreeControl HOT 1
- MinGW not properly checked for in macros.
- slider call SetFloatValue without calling onValueChanged HOT 5
- Slider margin and padding
- TreeControl extreme slow with many children (+workaround)
- Scroll control and tree views HOT 2
- Designer source? HOT 1
- ComboBox open list upward HOT 2
- ComboBox selected item name is null
- AltGR
- OnPress Callback
- Radial Menu?
- TreeControl - Nested Nodes Incorrect Positions.
- CrossSplitter Unable To Access Event Callbacks
- Controls::Layout::Table RowCount Unused Argument
- Controls::Textbox Spelling Error
- WindowControl DisableResizing Does Not Fully Disable
- File.h Including Wrong Header
- Gwen::ImagePanel* Gwen::Button::GetImage()
- GWEN OpenGL 3.x compatible renderer HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gwen.