Comments (2)
This was not a good change. You could have added a void* to the packet structure but replacing packet entirely with void* loses built in type safety and multi field ability of the user data for basic types, not to mention leaks memory for anything you allocate for the user data. I can understand the need to put more complex information in the packet than the types supported, but the fix for that isn't replacing it with void *. At a minimum you could add a void * to the packet. Even better, a little template wrapper could provide a type safe and memory leak safe wrapper around whatever pointer you allocate for the data.
from gwen.
This is the way other libraries do it so I just emulated them.
I'm sure there is a better way.
EDIT: Also, there is no memory leak here except for when people use it wrong.
You have to allocate the data the void pointer points to with new and later delete it.
from gwen.
Related Issues (20)
- Problem with TreeControl HOT 1
- MinGW not properly checked for in macros.
- slider call SetFloatValue without calling onValueChanged HOT 5
- Slider margin and padding
- TreeControl extreme slow with many children (+workaround)
- Scroll control and tree views HOT 2
- Designer source? HOT 1
- ComboBox open list upward HOT 2
- ComboBox selected item name is null
- AltGR
- OnPress Callback
- Radial Menu?
- TreeControl - Nested Nodes Incorrect Positions.
- CrossSplitter Unable To Access Event Callbacks
- Controls::Layout::Table RowCount Unused Argument
- Controls::Textbox Spelling Error
- WindowControl DisableResizing Does Not Fully Disable
- File.h Including Wrong Header
- Gwen::ImagePanel* Gwen::Button::GetImage()
- GWEN OpenGL 3.x compatible renderer HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gwen.