Giter Site home page Giter Site logo

Comments (2)

jswigart avatar jswigart commented on July 23, 2024

This was not a good change. You could have added a void* to the packet structure but replacing packet entirely with void* loses built in type safety and multi field ability of the user data for basic types, not to mention leaks memory for anything you allocate for the user data. I can understand the need to put more complex information in the packet than the types supported, but the fix for that isn't replacing it with void *. At a minimum you could add a void * to the packet. Even better, a little template wrapper could provide a type safe and memory leak safe wrapper around whatever pointer you allocate for the data.

from gwen.

Wizzard033 avatar Wizzard033 commented on July 23, 2024

This is the way other libraries do it so I just emulated them.

I'm sure there is a better way.

EDIT: Also, there is no memory leak here except for when people use it wrong.
You have to allocate the data the void pointer points to with new and later delete it.

from gwen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.