Missing check icon by using PopUp Window

[gatanaso]

Missing check icon by using PopUp Window

[gatanaso]

Hi @shand2

Thank you for opening this issue. It might as well be an issue with the web component, but I will let you know more once I have done an initial investigation.

BR,
Goran

[gatanaso]

Hi @shand2

I tried the following very simple demo:

@Route("")
public class DemoView extends VerticalLayout {

    public DemoView() {
        MultiselectComboBox<String> multiselectComboBox = new MultiselectComboBox();
        multiselectComboBox.setLabel("Multiselect combo box with string items");
        multiselectComboBox.setPlaceholder("Add");
        multiselectComboBox.setItems("Item 1", "Item 2", "Item 3", "Item 4");
        multiselectComboBox.addSelectionListener(event -> Notification.show(event.toString()));

        FormLayout content = new FormLayout();
        content.add(multiselectComboBox);

        VerticalLayout layout = new VerticalLayout();
        layout.add(content);

        Dialog dialog = new Dialog();
        dialog.add(layout);

        Button button = new Button("open dialog", click -> {
            dialog.open();
        });

        add(button);
    }

The check icons were correctly being displayed. Therefore I suspect the issue might be related to something else but I could not quite understand your code as the formatting seems to be a bit broken.

Could you please update the formatting, as well provide a minimal working example that reproduces this issue?

Thank you,
Goran

Hi Gatanaso,

here is a simple example of my project to reproduce the issue. After selection the content with the dialog button is loaded.

It is independent of using in a modal dialog or not

@route("")
public class DemoView extends VerticalLayout {

private final ComboBox<String> versionSelect = new ComboBox<>();

public DemoView() {
    versionSelect.setItems(Arrays.asList("test1", "test2"));
    add(versionSelect);
    versionSelect.addValueChangeListener(event -> {
        reloadContent();
    });
}

private void reloadContent() {

    MultiselectComboBox<String> multiselectComboBox = new MultiselectComboBox();
    multiselectComboBox.setLabel("Multiselect combo box with string items");
    multiselectComboBox.setPlaceholder("Add");
    multiselectComboBox.setItems("Item 1", "Item 2", "Item 3", "Item 4");
    multiselectComboBox.addSelectionListener(event -> Notification.show(event.toString()));

    FormLayout content = new FormLayout();
    content.add(multiselectComboBox);

    VerticalLayout layout = new VerticalLayout();
    layout.add(content);
    add(layout);
};

}

Thank you,
André

[gatanaso]

Hi @shand2

I created a new project, with one view and added the above code that you posted. Similarly as before, everything worked as expected.

Here is the project zip, for you to give it a try and let me know if it works on your side:
multiselect-combo-box-demo.zip

Additionally, since I am unable to reproduce the issue, could you please upload a zip of a project that reproduces the issue, as well provide more details on how you build and run the project and which browser(s) you use?

Kind regards,
Goran

Hi Goran,

here is a complete runnable example close to my project using gradle and SpringBoot.

multiselect-combo-box-demo.zip

I can reproduce the issue with chrome 76.x and firefox 60.x browser

King regards,
André

[gatanaso]

Hello @shand2

I think there has been some misunderstanding here :) The sample project you posted uses Vaadin 13:

The 2.x.x versions of this component are intended to work with Vaadin 14 in npm mode.

To use Vaadin 13 in bower mode, you should use the 1.x.x version of this component, more specifically the latest 1.0.1 version.

I only recently updated the version information for this component: https://github.com/gatanaso/multiselect-combo-box-flow#version-information

UPDATE: I was able to reproduce this issue with Vaadin 13 and will investigate further. Until I get it fixed I would suggest if it's possible that you update to Vaadin 14 as Vaadin 13 support ends in approximately two weeks.

Kind regards,
Goran

[gatanaso]

Hi @shand2

I think the above issue is quite interesting :) Basically the main cause of the problem was that not all dependencies were being loaded for the MultiselectComboBox when it was not initially added to the view (i.e. it was included via a dialog or in the selection handler).

To fix this you need to add the following annotation to your view:

@Uses(MultiselectComboBox.class)

For example, in the above project, that would be:

@Route("")
@Theme(Material.class)
@Uses(MultiselectComboBox.class)
public class DemoView extends VerticalLayout 

To explain why this is needed, here is a excerpt from the javadoc of the annotation:

/**
 * Marks that an annotated component implicitly uses another component. This
 * will ensure that any dependencies of the used component are also loaded....
 * ...
 * Marking class A with @Uses(B.class) will ensure all
 * @StyleSheet, @HtmlImport, @JavaScript dependencies for
 * class B are loaded when class A is used.
 */

BR,
Goran