Giter Site home page Giter Site logo

Comments (11)

matteocona avatar matteocona commented on September 18, 2024 1

Hi Goran,
sorry for the late reply.
It works.
Tested.

multiselect-combo-box-flow
version 2.5.0.rc1

vaadin version
14.2.0

Thanks a lot
Matteo

from multiselect-combo-box-flow.

gatanaso avatar gatanaso commented on September 18, 2024 1

Hi @mvysny,

Thanks for the comment and the reproducible steps. Yes, there is already a ticket about this issue: #56

Until I resolve it, you can try to workaround it by wrapping the component in a Div and changing its visibility (as it is suggested in the ticket).

from multiselect-combo-box-flow.

mvysny avatar mvysny commented on September 18, 2024 1

Thank you :) At first I thought it to be a Dialog-related issue, but it's really a visibility-related issue. I'll wrap the component with div as you suggest.

from multiselect-combo-box-flow.

gatanaso avatar gatanaso commented on September 18, 2024

Hi @matteocona,

Thanks for reporting this issue and providing a reproducible example. I believe it's related to the shadow dom not being initialized when the component is used in a dialog. Will need some time to further investigate and find a way to resolve this issue.

from multiselect-combo-box-flow.

matteocona avatar matteocona commented on September 18, 2024

Thank you very much,
Matteo

from multiselect-combo-box-flow.

gatanaso avatar gatanaso commented on September 18, 2024

Hi @matteocona,

Could you please test with the following version: 2.4.2 and let me know if it works?

BR,
Goran

from multiselect-combo-box-flow.

matteocona avatar matteocona commented on September 18, 2024

Hi Goran,
have you tried the component within a dialog also for Vaadin 14.1.x?

Thank you very much
Matteo

from multiselect-combo-box-flow.

gatanaso avatar gatanaso commented on September 18, 2024

Hi @matteocona,

I cannot recall at this time :) Are there any issues when using Vaadin 14.1.x ?

from multiselect-combo-box-flow.

mvysny avatar mvysny commented on September 18, 2024

Hi @gatanaso unfortunately the component is not initialized properly when it is initially invisible within the dialog (sorry :-) ). The following code demoes the issue:

@Route("")
public class MainView extends VerticalLayout {

    public MainView() {
        Button button = new Button("Click",
                e ->  {
                    final Dialog dlg = new Dialog();
                    final MultiselectComboBox<String> cb = new MultiselectComboBox<>("Hi Goran", "Really", "Sorry", "For", "Finding", "Bugs", ":-)");
                    cb.setVisible(false);
                    dlg.add(cb);
                    dlg.add(new Button("Show", a -> cb.setVisible(true)));
                    dlg.open();
                });

        add(button);
    }
}

Using Maven multiselect-combo-box-flow:2.5.0.rc1 which uses [email protected]

Should I file this a new bug please?

from multiselect-combo-box-flow.

Sryther avatar Sryther commented on September 18, 2024

Hi, I could not achieve to display the multiselect like it did before the vaadin 14 upgrade. It worked in the past and since I updated and switched to Material theme I had no luck with it.
I'm in the same situation: the combobox in a dialog.

This a sample of my code:

MultiselectComboBox<XX> multiselectComboBox = new MultiselectComboBox<>("", XX.values());
multiselectComboBox.setValue(XX.Y);

Dialog dialog = new Dialog();
dialog.add(multiselectComboBox);

// Prepare the button that displays the multi statuses filter.
Button button = new Button(new Icon(VaadinIcon.FILTER), event -> {
    dialog.open()
});

When I click on the button, I have the (TypeError) : $0.$connector is undefined error and (TypeError) : window.Vaadin.Flow.multiselectComboBoxConnector is undefined.

I'm using Maven:

<dependency>
	<groupId>org.vaadin.gatanaso</groupId>
	<artifactId>multiselect-combo-box-flow</artifactId>
	<version>2.4.2</version>
</dependency>

Any ideas?

By the way, thank you very much for this component, it did save a lot of time :).

EDIT: I tried to use a wrapper element as suggested (div) but it didn't work for me.

from multiselect-combo-box-flow.

gatanaso avatar gatanaso commented on September 18, 2024

@Sryther Thanks for the feedback, I really appreciate it.

Regarding your issue, it looks same as the one that was opened here originally. Might be then that something has changed in the way Vaadin initialises the dialog. Which version did you upgrade to, have you tried with another one perhaps?

Also, in the spirit of keeping things a bit more organised, I'd kindly ask if you can open a new issue and we continue the discussion there.

Thanks

from multiselect-combo-box-flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.