.gmailieer.json destroyed when running out of space

[gauteh]

.gmailieer.json destroyed when running out of space

[julian-klode]

Yeah, sure, I can send a pull request later.

[julian-klode]

(Same for all files, really)

[julian-klode]

The first fix is easy:

diff --git a/lieer/local.py b/lieer/local.py
index 70f8cc9..889b3c7 100644
--- a/lieer/local.py
+++ b/lieer/local.py
@@ -77,8 +77,9 @@ class Local:
       self.json['account'] = self.account
       self.json['timeout'] = self.timeout
 
-      with open (self.state_f, 'w') as fd:
+      with open (self.state_f + ".new", 'w') as fd:
         json.dump (self.json, fd)
+      os.rename(self.state_f + ".new", self.state_f)
 
     def set_last_history_id (self, hid):
       self.last_historyId = hid

The handling in store() is wrong generally: It should first write the message to tmp/ and then move it into cur/ really (actually, it'd have to go via new, but you can't have flags there, so ...).

[julian-klode]

So I'd probably just build a helper class here that gives an atomic file inside tmp/ when you open() it, and when it's closed renames that for you, that's the best abstraction really.

[gauteh]

In the notmuch system i think it should just go directly in cur. Good suggestions, do you have a chance to make a PR? lør. 1. jul. 2017 kl. 23.54 skrev Julian Andres Klode < [email protected]>:

…

So I'd probably just build a helper class here that gives an atomic file inside tmp/ when you open() it, and when it's closed renames that for you, that's the best abstraction really. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADd-0gzBF1QbGSpzFIx0Je1tiUPMYCaks5sJsArgaJpZM4OLbFd> .

[gauteh]

Fixed in master.