Pull Request for Apply/Emit pattern

[gautema]

Pull Request for Apply/Emit pattern

[gautema]

I am a bit uncertain about this change. First, I don't want to change the API, since it would be a change to existing users, so changing ApplyChange to Emit seems unnecessary even if the naming might be better. Second, now it's voluntary to implement apply, and this is a feature, not a bug. If you don't need any data from the event to do validation or perform business logic in the model, there is no need to implement the Apply method.

[minhhungit]

changing ApplyChange to Emit seems unnecessary

agree with you about this, we don't need to change it, we can keep it as "ApplyChange"

yeah, this is just a feature, not bug but it will help us maintain events easier

[petersondrew]

The code could be changed to first safely cast to an interface and call apply if it is not null, then attempt the dynamic call if it is null. That may balance the performance with the optional implementation of Apply, without effecting existing code

[minhhungit]

If you worry then just add IEmit interface, don't change anything else