Comments (15)
Thanks for the reminder to close! @jipiboily see the folder godot4/ that contains the Godot 4 port of the demos
from godot-procedural-generation.
Let's go ahead an change it together. I'd love some constructive feedback. I expect to be done with infinite worlds and cellular automota in the next few days. The course text will also need to be updated eventually.
from godot-procedural-generation.
Good news for you! Contributor @tlobig has been porting this project to Godot 4: https://github.com/tlobig/godot-procedural-generation/tree/godot4update
I haven't had the time to review this yet but Godot 4 support is in the works
from godot-procedural-generation.
thanks for the mention @NathanLovato
I'm close to done with the first pass, only the last to parts of the course are not yet ported.
The code has a lot of comments to help with review, but should go before a merge.
Finally the new capabilities of Godot 4 enable a few ways to better structure the code and I will not have fully leveraged this on the first pass.
from godot-procedural-generation.
Don't hesitate to open a pull request once you'd like a review. We can directly refactor on top of your work + share insights on the changes if you're comfortable with that, which is the most efficient review option, or we can provide comments for you to make changes yourself if you prefer.
from godot-procedural-generation.
Awesome! Thank you very much!
from godot-procedural-generation.
I touched everything in the godot folder and have even started on a second pass through, tidying up some things in the basic dungeon and random walker parts. I will now await further direction before cleaning up the rest. Meanwhile all demos are in a usable state with Godot 4.0 stable
from godot-procedural-generation.
Awesome! Most of them works!
But some like the MSTDungeon and RandomWalker have the error "Parser Error: Unable to iterate on object of type "Node"."
from godot-procedural-generation.
Thank you for testing. Try RandomWalker again, I think the error you mention is only in MSTDungeon and it looks like a new issue that came with the stable 4.0 release.
from godot-procedural-generation.
I pushed an update for MSTDungeon, it still crashes if I remove the print statement print("_add_rooms") which is super weird. Could be anything. So, it works now, but this lurking bug needs to be squashed.
from godot-procedural-generation.
Thank you! RandomWalker works fine.
That bug is quite weird indeed.
from godot-procedural-generation.
@tlobig thank you so much! I really want to give you a proper review quickly but I'm still overloaded with work with GDC next week. I'll ask the teammate who put the most work on this project if he can handle that. He works at GDQuest Thursday to Saturday.
from godot-procedural-generation.
@NathanLovato please don't stress yourself out about this review. You obviously have to have your mind on GDC now. All in good time. I just wish I had more time to spend on things like these - is all I'll allow myself to publicly state.
from godot-procedural-generation.
Any news on review and the update to the course by any chance? :)
from godot-procedural-generation.
from godot-procedural-generation.
Related Issues (9)
- LayeredWorld.gd has unreliable planet retention and spawning issues HOT 4
- update to godot 4.3 HOT 1
- Writing generation data to a file !!! HOT 2
- Add cellular automata demos HOT 2
- SpaceInfiniteGeneration README inconsistency
- numerous examples do not work HOT 3
- Potentially misnamed var `_total_sector_count` & suggestion HOT 3
- GDQuest and some of its members will be crushed very soon hopefully
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot-procedural-generation.