New Eager Loading Bug!

[danfinlay]

New Eager Loading Bug!

[ben-ng]

Woah! Nice find, I'll take a look after work 😊

[danfinlay]

My guess is that this condition should be modified to say:

    if (skip && !query.opts.includes) {

I might have time to check if that works after lunch. Haven't gotten Model's tests running locally somehow. Need to take the time.

[danfinlay]

Actually that could be the pre-query, not sure..

[ben-ng]

had an unusually long day at work, going to have to defer this to tomorrow 😞

ping me on twitter if i forget! i have it on my to-do list.

[danfinlay]

Yeah no hard feelings, I had a long day too. Hope you beat those tasks back soon!

[danfinlay]

I wrote a test for what I described, but it's passing. If I can't replicate this soon I'll just close it, maybe something else is going on.

These tests seem to suggest that having an offset of 2 will wrap around the set if there are only two results for the query.