Badge Font Size No Longer Changeable

[geekyants]

Badge Font Size No Longer Changeable

[sankhadeeproy007]

Change it in light.js

[zzimbler]

doesn't that defeat the purpose of including a library if you have to manually edit it to change something that seems like it would be changeable via props?

[sankhadeeproy007]

The point of using variables is that, you can define it in one place and it remains consistent throughout your application. But since some people aren't big fans of the DRY approach, we'll add it with textStyle in our next release.

[zzimbler]

I guess my point is mainly that if you're working on a project with someone
or a team of devs and using this library you'd have to create your own fork
to manage those variables because the base import from npm installing your
package won't have your custom variables. Perhaps forcing a vars file or
something a the root of the application that defines everything is
approachable? DRY is ideal.. that being said it's a pain in the ass to have
to manage your own fork for every library you want to include in your
application too.

On Mon, Jul 18, 2016 at 11:28 PM Sankhadeep Roy [email protected]
wrote:

The point of using variables is that, you can define it in one place and
it remains consistent throughout your application. But since some people
aren't big fans of the DRY approach, we'll add it with textStyle in our
next release.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAg4DA8IfldyaPRIprBybjVIrlQa79gvks5qXGCVgaJpZM4I37et
.

Zachary Zimbler
814-441-2968
http://zzimbler.com

[sankhadeeproy007]

I understand your problem. It indeed can get difficult to manage. That is why there is another option of having your own variable.js file, and import from there.

import theme from '../{variable.js path}';
<Container theme={theme}>
// your content
</Container>

[zzimbler]

ah, that should work. thanks

On Mon, Jul 18, 2016 at 11:36 PM Sankhadeep Roy [email protected]
wrote:

I understand your problem. It indeed can get difficult to manage. That is
why there is another option of having your own variable.js file, and import
from there.

import theme from '../{variable.js path}';

// your content

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#46 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAg4DJfbYNTP61zJrYV05VwRfiJi82Ltks5qXGJcgaJpZM4I37et
.

Zachary Zimbler
814-441-2968
http://zzimbler.com

[sankhadeeproy007]

Cool, just copy over all the contents of light.js to your file and set your own default values.