error in BG currents

[gemini3d]

error in BG currents

[mattzett]

There is actually more to the problem than this... e594245 produces correct output for current densities but the current commit does not... The is likely related to the refactor of potential source terms... 06bb283 also checks out as being correct... af12f88 appears to have a problem... c034ba5 also has a problem... f7962da appears to give correct results... 9d3707e is incorrect... b6bad22 is also incorrect which makes it the first commit giving clearly wrong results.

[mattzett]

The source of this problem appears to be the neutral_update subroutine, though it's not clear why that is causing issues... The problem may be the typo in setting the background values for winds

subroutine neutral_update(nn,Tn,vn1,vn2,vn3)

! adds stored base and perturbation neutral atmospheric parameters (these are module-scope parameters so not needed as input)

real(wp), dimension(:,:,:,:), intent(out) :: nn
real(wp), dimension(:,:,:), intent(out) :: Tn
real(wp), dimension(:,:,:), intent(out) :: vn1,vn2,vn3


!> background neutral parameters
nn=nnmsis
Tn=Tnmsis
vn1=vn1base
vn2=vn2base
vn2=vn3base     ! typo...

!!> perturbations, if used
if (allocated(zn)) then
  nn(:,:,:,1)=nn(:,:,:,1)+dnOinow
  nn(:,:,:,2)=nn(:,:,:,2)+dnN2inow
  nn(:,:,:,3)=nn(:,:,:,3)+dnO2inow
  nn(:,:,:,1)=max(nn(:,:,:,1),1._wp)
  nn(:,:,:,2)=max(nn(:,:,:,2),1._wp)
  nn(:,:,:,3)=max(nn(:,:,:,3),1._wp)

  Tn=Tn+dTninow
  Tn=max(Tn,50._wp)

  vn1=vn1+dvn1inow
  vn2=vn2+dvn2inow
  vn3=vn3+dvn3inow
end if

end subroutine neutral_update

[mattzett]

67a6f99 appears to resolve the issue...