capture example does not compile

[gen2brain]

capture example does not compile

[danfletcher1]

Do you want to try these changes.

// This example simply captures data from your default microphone until you press Enter, after which it plays back the captured audio.
package main

import (
"fmt"
"os"

"github.com/gen2brain/malgo"

)

func main() {
ctx, err := malgo.InitContext(nil, malgo.ContextConfig{}, func(message string) {
fmt.Printf("LOG <%v>\n", message)
})
if err != nil {
fmt.Println(err)
os.Exit(1)
}
defer func() {
_ = ctx.Uninit()
ctx.Free()
}()

deviceConfig := malgo.DefaultDeviceConfig()
deviceConfig.DeviceType = 3
deviceConfig.Capture.Format = malgo.FormatS16
deviceConfig.Capture.Channels = 1
deviceConfig.Playback.Format = malgo.FormatS16
deviceConfig.Playback.Channels = 1
deviceConfig.SampleRate = 8000
deviceConfig.Alsa.NoMMap = 1

var playbackSampleCount uint32
var capturedSampleCount uint32
pCapturedSamples := make([]byte, 0)

sizeInBytes := uint32(malgo.SampleSizeInBytes(deviceConfig.Capture.Format))
onRecvFrames := func(pSample2, pSample []byte, framecount uint32) {

	sampleCount := framecount * deviceConfig.Capture.Channels * sizeInBytes

	newCapturedSampleCount := capturedSampleCount + sampleCount

	pCapturedSamples = append(pCapturedSamples, pSample...)

	capturedSampleCount = newCapturedSampleCount

}

fmt.Println("Recording...")
captureCallbacks := malgo.DeviceCallbacks{
	Data: onRecvFrames,
}
device, err := malgo.InitDevice(ctx.Context, deviceConfig, captureCallbacks)
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

err = device.Start()
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

fmt.Println("Press Enter to stop recording...")
fmt.Scanln()

device.Uninit()

onSendFrames := func(pSample, nil []byte, framecount uint32) {
	samplesToRead := framecount * deviceConfig.Playback.Channels * sizeInBytes
	if samplesToRead > capturedSampleCount-playbackSampleCount {
		samplesToRead = capturedSampleCount - playbackSampleCount
	}

	copy(pSample, pCapturedSamples[playbackSampleCount:playbackSampleCount+samplesToRead])

	playbackSampleCount += samplesToRead

	if playbackSampleCount == uint32(len(pCapturedSamples)) {
		playbackSampleCount = 0
	}
}

fmt.Println("Playing...")
playbackCallbacks := malgo.DeviceCallbacks{
	Data: onSendFrames,
}

device, err = malgo.InitDevice(ctx.Context, deviceConfig, playbackCallbacks)
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

err = device.Start()
if err != nil {
	fmt.Println(err)
	os.Exit(1)
}

fmt.Println("Press Enter to quit...")
fmt.Scanln()

device.Uninit()

}

[djadala]

Thank you (Хвала ?).
At least it compile, i test it later when i have mic ...
may be s/deviceConfig.DeviceType = 3/deviceConfig.DeviceType = malgo.Duplex/ ?

[djadala]

Yes, it works,
can i afford to recommend some style ?

s/
nSendFrames := func(pSample, nil []byte, framecount uint32) {
/
nSendFrames := func(pSample, _ []byte, framecount uint32) {
/

s/
onRecvFrames := func(pSample2, pSample []byte, framecount uint32) {
/
onRecvFrames := func(_, pSample []byte, framecount uint32) {
/

[danfletcher1]

Appreciate the feedback. I did remember to remove the pSample2 before posting the pull request, but I never though to use _ for nil. Thanks for the tip.

…

On Tue, 8 Oct 2019 at 07:49, Jamil Djadala ***@***.***> wrote: Yes, it works, can i afford to recommend some style ? s/ nSendFrames := func(pSample, nil []byte, framecount uint32) { / nSendFrames := func(pSample, _ []byte, framecount uint32) { / s/ onRecvFrames := func(pSample2, pSample []byte, framecount uint32) { / onRecvFrames := func(_, pSample []byte, framecount uint32) { / — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AEC3XN2VVNSAGH3QI3LR773QNQUPRA5CNFSM4I56EMN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEATBMYQ#issuecomment-539367010>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEC3XN4DDYBODZUYC4OUKZLQNQUPRANCNFSM4I56EMNQ> .

[djadala]

actually nil here is variable name:
https://play.golang.org/p/yGW0r-fc3_K

[danfletcher1]

Oh yes, so it is.
I tried 'true', 'error', '5' also. Good clarification of the language.
As expected 5 is 5, but the reserved keywords of true/nil/error will become variable name, and true will no longer mean true.

[egonelbre]

This should be fixed currently.