Giter Site home page Giter Site logo

Comments (13)

b-g avatar b-g commented on May 22, 2024

@generative-design/authors Can everyone please check this ... and tell us the behaviour on their machines? Please use the branch pre-release for testing.

from code-package-p5.js.

bohnacker avatar bohnacker commented on May 22, 2024

I've added v0.5.12, v0.5.14 and 0.5.16 to the libraries folder to make it easier for you to test.

from code-package-p5.js.

bohnacker avatar bohnacker commented on May 22, 2024

And added a test folder.

from code-package-p5.js.

joeyklee avatar joeyklee commented on May 22, 2024

On my machine... macbook pro v10.12

on chrome 63.0.3239.132 (Official Build) (64-bit):

  • index-v0.5.12 is the snappiest. Then the current and 0.5.14 are roughly the same.

on firefox 57.0.4 (64-bit):

  • index-v0.5.12 performs slightly better than the others. The current and 0.5.14 perform roughly the same.

from code-package-p5.js.

bohnacker avatar bohnacker commented on May 22, 2024

Same here. Tested with chrome 64.0.3282.85 (64-bit) and firefox 57.0.4 (64-bit) on macbook pro with os x 10.12.
p5 v0.5.12 is at least twice as fast than v0.5.14 or 16.

from code-package-p5.js.

joeyklee avatar joeyklee commented on May 22, 2024

Thanks for looking into it @bohnacker ! How do you think we should proceed?

from code-package-p5.js.

b-g avatar b-g commented on May 22, 2024

@joeyklee Can you ask via your insider link the p5js dev whether this is a know issue and whether there is a new version coming up addressing this? I couldn't find in any pointers in the release notes ... and @bohnacker said he couldn't find any slow perf issues on the p5 github either.

from code-package-p5.js.

joeyklee avatar joeyklee commented on May 22, 2024

@b-g does it make sense to post to the P5js issues? If so, then I'd reference our issue thread here for reference and then reach out to our contacts. Cool?

from code-package-p5.js.

b-g avatar b-g commented on May 22, 2024

@joeyklee please!

from code-package-p5.js.

joeyklee avatar joeyklee commented on May 22, 2024

Please see discussion forming here: processing/p5.js#2549 (comment)

from code-package-p5.js.

joeyklee avatar joeyklee commented on May 22, 2024

@bohnacker I added p5.disableFriendlyErrors = true; to the beginning of the sketch.js in the test. It feels that it does indeed improve the performance. Please give it a try to see if you also notice that there is a speed up.

from code-package-p5.js.

bohnacker avatar bohnacker commented on May 22, 2024

@joeyklee Gave it a try with the test sketch and the frameRate seems again similar to v0.5.12. I'm not sure what to do. It sounds like the new "friendlyErrors" feature would be something that we want to keep for our sketches. Still, for some of the book sketches it would be nicer to have the frameRate as fast as possible.

We should probably pick the sketches by hand where we add this line.

from code-package-p5.js.

bohnacker avatar bohnacker commented on May 22, 2024

Just tried the test sketch with the current verision (0.5.16) of p5.min.js. It is another 10 to 20% faster than the corresponding p5.js. So best would be to switch to the min versions. That also would keep the additional line out of our sketches.
I'll do that and close this issue afterwards.

from code-package-p5.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.