Giter Site home page Giter Site logo

Comments (4)

bangerth avatar bangerth commented on June 4, 2024

The code happens to be correct for the incompressible case, but is surely wrong for the compressible case.

from aspect.

jdannberg avatar jdannberg commented on June 4, 2024

Okay, I just had a look at the equation in Schubert, Turcotte & Olson, and I think equation (3) in the manual is correct even for the compressible case, but not for non-Newtonian fluids. In the book (part 1, page 202, equation 6.9.3), the shear heating term is written as \Phi = sigma_i,j * du_i / dx_j. For compressible Newtonian fluids we should have the correct formulation exactly as written in eq. (6.9.4) with bulk viscosity = 0.
However, it would be nice to have some more documentation about how this term is implemented (similar to the Compressible formula section in the manual). From the comments in assembly.cc, it was not clear for me why we have to replace div u...
In addition, we should think about what to do for the non-Newtonian case...

from aspect.

jdannberg avatar jdannberg commented on June 4, 2024

This should also be fixed now by #498, right?

from aspect.

gassmoeller avatar gassmoeller commented on June 4, 2024

This is fixed with the new heating formulation.

from aspect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.