Missing 'distance' field on returned instances

[geokit]

Missing 'distance' field on returned instances

[speakingcode]

Is there no way to get the actual distance? I don't want to sort by distance i want to display the distance to my user, I need the actual field... how to get the distance field?

[xnzac]

Not sure how to add this to a github message, but I resolved the issue by reversing the regressive commit: xnzac@15dd4b6

And then 'distance' is back!

[dougc84]

+1 on this. @zaczheng 's fix works - can you do a PR on this?

[xnzac]

The repo owner wanted to extract the distance calculation out. See the following commit:

f79bbdf
"I've pushed a new commit with a helper method and some tests and removes the Array sort_by_distance_from method alltogether."

[mnoack]

I'm open to PRs but overriding core classes is best avoided for specific uses.

[mnoack]

Yes, so the new way of doing it (see test in commit referenced above) is:
unsorted_collection = DistanceCollection.new(unsorted)
unsorted_collection.set_distance_from(locations(:a))
unsorted_collection.sort_by(&:distance)

I would happy accept something like:

class DistanceCollection
  def sort_by_distance_from(origin, opts = {})
    set_distance_from(origin)
    sort_by(&:distance)
  end
end

This would enable a shorter usage like:

DistanceCollection.new(unsorted).sort_by_distance_from(origin)

[hcyildirim]

@speakingcode did you figured it out? i need help 😞 @mnoack

[BilalAamirr]

Did anyone figured it out? @ccoeder ?

[hcyildirim]

You can look at this issue, there is patch on that #56