[BUG/ISSUE] Invalid compile command for hemco_standalone.x on Ubuntu

[geoschem]

[BUG/ISSUE] Invalid compile command for hemco_standalone.x on Ubuntu

[yantosca]

I pushed a fix for this. We use the Makefile_header.mk variable IS_HPC to prevent building the hemco_standalone.x executable if we are building GC for an HPC environment.

  	@$(MAKE) libHCO
  	@$(MAKE) libHCOX
  	@$(MAKE) libHCOI
ifeq ($(IS_HPC),0)
 	@$(MAKE) exe
endif

[JiaweiZhuang]

A better way to skip hemco_standalone.x is changing HEMCO/Makefile:

from

all:
	@$(MAKE) lib

...

lib:
	@$(MAKE) libHCO
	@$(MAKE) libHCOX
	@$(MAKE) libHCOI
	@$(MAKE) exe

to

all:
	@$(MAKE) lib
	@$(MAKE) exe
...

lib:
	@$(MAKE) libHCO
	@$(MAKE) libHCOX
	@$(MAKE) libHCOI

This feels a lot more intuitive as lib only contains object files while all also contains executable.

Right now the above all target is not used at all. The top-level GeosCore/Makefile only goes to lib:

libhemco:                                          # Build code in HEMCO/*
	@$(MAKE) -C $(HEMCO) lib

So, hemco_standalone.x will not be compiled in any case, for both classic and HP.

If users do want to get hemco_standalone.x, the above unused all can be used to implement one more option, like:

hemco_standalone:                                          # Build hemco_standalone.x
	@$(MAKE) -C $(HEMCO) all

[lizziel]

Thanks for coming up with this solution. In the past I adjusted the makefile during debugging to skip compiling the HEMCO standalone since it is indeed not used. It makes sense to make this the default. I will keep this issue open until we put it into an upcoming version and test it.