Giter Site home page Giter Site logo

Comments (5)

basaks avatar basaks commented on July 26, 2024

@alexgorb how critical is this? Or are we ok for now?

We have the ellipticity correction working, so this should not be too difficult to implement, but the integration to the clustering code is yet to be done.

from hiperseis.

alexgorb avatar alexgorb commented on July 26, 2024

from hiperseis.

basaks avatar basaks commented on July 26, 2024

We should also package the fortran code of ellipticity corection with passive-seismic for one step installation: #65.

from hiperseis.

basaks avatar basaks commented on July 26, 2024

This has been achieved in # 4537ea7.

However, @alexgorb , we have to pay some attention to ellipticity correction parameters used in the fortran code here. Specifically, the ecolat parameter has been defined as the co-latitude of the event location. However, and I have a TODO in the code, we need to make sure that the events that we are gathering arrivals from have latitudes defined in range (-90 to 90).

From the TODO:

# TODO: check co-latitude definition
# no `ecolat` bounds check in fortran ellipcorr subroutine
# no `origin.latitude` bounds check in obspy

Keeping this open for now until those are confirmed.

from hiperseis.

basaks avatar basaks commented on July 26, 2024

@alexgorb The above is important as if the events have their origins defined using a different range of latitudes, will result in wrong ellipticity corrections as the clustering code expects latitude defined in range [-90, 90] and converts the latitude to co-latitude.

from hiperseis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.