Giter Site home page Giter Site logo

Comments (5)

bsmurphy avatar bsmurphy commented on August 26, 2024

Yeah, this is a really good idea. Maybe we could implement an option for no output, printed output, or log output. Definitely something good for v2.

from pykrige.

rth avatar rth commented on August 26, 2024

@basaks I'm not sure about this. Wouldn't just printing and rasing warning be enough? And then let logging be handled by the user application?

For instance, numpy, scipy, scikit-learn don't use the logging module in the core library, which allows more flexibility for the end user to use this logging module or not in their code and also keeps things simpler...

from pykrige.

1kastner avatar 1kastner commented on August 26, 2024

Well, the logging module allows great flexibility and makes things easier. You can choose an arbitrary name, e.g. logging.getLogger("bsmurphy/PyKrige") and then disable propagation. That way you will never interfere with whatever choices the end user does for their application. But the end user can choose what they want to log and where it should be logged. Printing the output is a less-favorable solution because unlike logging it is not possible for the end user to control the output at a later stage.

from pykrige.

rth avatar rth commented on August 26, 2024

@1kastner I see your point. For reporting "events that occur during normal operation of a program" cf logging docs that currently use print when verbose=True this would indeed be better. For warnings though, warnings.warn might be more appropriate. Pull Requests welcome )

from pykrige.

1kastner avatar 1kastner commented on August 26, 2024

I agree that warnings.warn is more suitable than logging.warning in this context.

from pykrige.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.